Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRespect Buildbot invariants when adding new steps #501
Conversation
|
@bors-servo r+ |
|
|
aneeshusa
force-pushed the
aneeshusa:respect-buildbot-invariants
branch
from
f48c2e4
to
d348fbd
This will prevent crashes when Buildbot tries to execute dynamically added steps.
aneeshusa
force-pushed the
aneeshusa:respect-buildbot-invariants
branch
from
d348fbd
to
e9f0519
|
OK, fixed the syntax bugs and tidy. |
|
@bors-servo r+ |
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 3, 2016
…gstrom Respect Buildbot invariants when adding new steps This will prevent crashes when Buildbot tries to execute dynamically added steps. I'm not sure if I got everything needed, so this may require some followups. Part of #316. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/501) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedOct 3, 2016
•
edited by larsbergstrom
This will prevent crashes when Buildbot tries to execute dynamically
added steps.
I'm not sure if I got everything needed, so this may require some followups.
Part of #316.
This change is