Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPropagate default workdir for newly created steps #502
Conversation
The StepsYAMLParsingStep is statically in the step list of the factory, so when starting a build Buildbot will call `setDefaultWorkdir` on each step. We need to save this value and propagate it to the steps we create on the fly to ensure they also receive a workdir value.
|
@bors-servo r+ |
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 4, 2016
…arsbergstrom Propagate default workdir for newly created steps The StepsYAMLParsingStep is statically in the step list of the factory, so when starting a build Buildbot will call `setDefaultWorkdir` on each step. We need to save this value and propagate it to the steps we create on the fly to ensure they also receive a workdir value. Another step towards #316. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/502) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedOct 3, 2016
•
edited by larsbergstrom
The StepsYAMLParsingStep is statically in the step list of the factory,
so when starting a build Buildbot will call
setDefaultWorkdiron eachstep. We need to save this value and propagate it to the steps we
create on the fly to ensure they also receive a workdir value.
Another step towards #316.
This change is