Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`mach package` treated as a steps.Compile #503

Merged
merged 1 commit into from Oct 12, 2016
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Treat './mach package' as a steps.Compile

Even when this command fails, Buildbot still goes on to run the next
step, because it is run as a simple ShellCommand.

Instead, we now check for it in the `make_step` function and use
`steps.Compile` to create the step as it is not only a closer semantic
match (we're "compiling" the package) but it also makes it so when it
fails Builbot doesn't ignore it or move on to the next step.
  • Loading branch information
lucasloisp committed Oct 5, 2016
commit 9296512d89714c2a38cff992fe8813f496c0e78d
@@ -106,6 +106,8 @@ def make_step(self, command):
step_desc = [mach_arg]
if re.match('build(-.*)?', mach_arg):
step_class = steps.Compile
elif re.match('package', mach_arg):
step_class = steps.Compile
elif re.match('test-.*', mach_arg):
step_class = steps.Test

@@ -251,6 +253,8 @@ def make_step(self, command):
step_desc = [mach_arg]
if re.match('build(-.*)?', mach_arg):
step_class = steps.Compile
elif re.match('package', mach_arg):
step_class = steps.Compile
elif re.match('test-.*', mach_arg):
step_class = steps.Test

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.