Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd release stylo unit tests #508
Conversation
|
@bors-servo r+ Let's see how the timing works out in production and we can shuffle things around as-needed. I'd probably be OK with either moving the "stable" rust stuff on top of In general I somewhat prefer more builders doing different things than glomming unrelated things into the same builder except in the case where they can share artifacts in the |
|
|
|
|
Add release stylo unit tests servo/servo#13700 moved some important binding layout tests to test-stylo (they used to be run by the regen script). Currently test-stylo is only run in debug mode. This runs it in release mode as well. Since linux-rel-css already contains a `./mach build-geckolib --release`, and `test-stylo` just needs a rebuild of style and geckolib (which takes half a minute), this shouldn't cause much of an issue. However, linux-rel-css is one of our slowest builders. Perhaps both `build-geckolib --release` and `test-stylo --release` should be put in linux-dev instead? r? @larsbergstrom <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/508) <!-- Reviewable:end -->
|
Note that release geckolib does not share artefacts with release servo. So there's no advantage to keeping it in a |
|
Please file a follow up PR to servo/servo to sync the steps.yml again in anticipation of #504. (Also see servo/servo#13611). |
Add release test-stylo to buildbot steps, servo/saltfs#508 (comment) r? @aneeshusa <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13720) <!-- Reviewable:end -->
…/saltfs#508 (comment) (from Manishearth:resync-yml); r=aneeshusa r? @aneeshusa Source-Repo: https://github.com/servo/servo Source-Revision: 4034bd68c2b2b9b899ecfb6e0d2b3ba17109c5ae
…/saltfs#508 (comment) (from Manishearth:resync-yml); r=aneeshusa r? aneeshusa Source-Repo: https://github.com/servo/servo Source-Revision: 4034bd68c2b2b9b899ecfb6e0d2b3ba17109c5ae UltraBlame original commit: 9c339f7972bad5b87662d79c3612ec644c142cd4
…/saltfs#508 (comment) (from Manishearth:resync-yml); r=aneeshusa r? aneeshusa Source-Repo: https://github.com/servo/servo Source-Revision: 4034bd68c2b2b9b899ecfb6e0d2b3ba17109c5ae UltraBlame original commit: 9c339f7972bad5b87662d79c3612ec644c142cd4
…/saltfs#508 (comment) (from Manishearth:resync-yml); r=aneeshusa r? aneeshusa Source-Repo: https://github.com/servo/servo Source-Revision: 4034bd68c2b2b9b899ecfb6e0d2b3ba17109c5ae UltraBlame original commit: 9c339f7972bad5b87662d79c3612ec644c142cd4
Manishearth commentedOct 12, 2016
•
edited by larsbergstrom
servo/servo#13700 moved some important binding layout tests to test-stylo (they used to be run by the regen script).
Currently test-stylo is only run in debug mode. This runs it in release mode as well.
Since linux-rel-css already contains a
./mach build-geckolib --release, andtest-stylojust needs a rebuild of style and geckolib (which takes half a minute), this shouldn't cause much of an issue.However, linux-rel-css is one of our slowest builders. Perhaps both
build-geckolib --releaseandtest-stylo --releaseshould be put in linux-dev instead?r? @larsbergstrom
This change is