Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release stylo unit tests #508

Merged
merged 1 commit into from Oct 12, 2016
Merged

Add release stylo unit tests #508

merged 1 commit into from Oct 12, 2016

Conversation

@Manishearth
Copy link
Member

Manishearth commented Oct 12, 2016

servo/servo#13700 moved some important binding layout tests to test-stylo (they used to be run by the regen script).

Currently test-stylo is only run in debug mode. This runs it in release mode as well.

Since linux-rel-css already contains a ./mach build-geckolib --release, and test-stylo just needs a rebuild of style and geckolib (which takes half a minute), this shouldn't cause much of an issue.

However, linux-rel-css is one of our slowest builders. Perhaps both build-geckolib --release and test-stylo --release should be put in linux-dev instead?

r? @larsbergstrom


This change is Reviewable

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Oct 12, 2016

@bors-servo r+

Let's see how the timing works out in production and we can shuffle things around as-needed. I'd probably be OK with either moving the "stable" rust stuff on top of linux-dev or creating a linux-rel-stable builder and doing the work there, on the assumption that we will eventually build+test more of Servo's tree on stable.

In general I somewhat prefer more builders doing different things than glomming unrelated things into the same builder except in the case where they can share artifacts in the CARGO_TARGET_DIR.

@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2016

📌 Commit 55d2a8d has been approved by larsbergstrom

@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2016

Test exempted - status

@bors-servo bors-servo merged commit 55d2a8d into servo:master Oct 12, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test exempted
Details
bors-servo added a commit that referenced this pull request Oct 12, 2016
Add release stylo unit tests

servo/servo#13700 moved some important binding layout tests to test-stylo (they used to be run by the regen script).

Currently test-stylo is only run in debug mode. This runs it in release mode as well.

Since linux-rel-css already contains a `./mach build-geckolib --release`, and `test-stylo` just needs a rebuild of style and geckolib (which takes half a minute), this shouldn't cause much of an issue.

However, linux-rel-css is one of our slowest builders. Perhaps both `build-geckolib --release` and `test-stylo --release` should be put in linux-dev instead?

r? @larsbergstrom

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/508)
<!-- Reviewable:end -->
@Manishearth Manishearth deleted the Manishearth:stylo-rel branch Oct 12, 2016
@Manishearth
Copy link
Member Author

Manishearth commented Oct 12, 2016

Note that release geckolib does not share artefacts with release servo. So there's no advantage to keeping it in a -rel builder aside from consistent naming. The disadvantage is that the crates (which may have different versions) will get downloaded again, as will rust stable (though that will only happen every now and then)

@aneeshusa
Copy link
Member

aneeshusa commented Oct 12, 2016

Please file a follow up PR to servo/servo to sync the steps.yml again in anticipation of #504. (Also see servo/servo#13611).

Manishearth added a commit to Manishearth/servo that referenced this pull request Oct 12, 2016
bors-servo added a commit to servo/servo that referenced this pull request Oct 12, 2016
Add release test-stylo to buildbot steps, servo/saltfs#508 (comment)

r? @aneeshusa

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13720)
<!-- Reviewable:end -->
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Feb 4, 2017
…/saltfs#508 (comment) (from Manishearth:resync-yml); r=aneeshusa

r? @aneeshusa

Source-Repo: https://github.com/servo/servo
Source-Revision: 4034bd68c2b2b9b899ecfb6e0d2b3ba17109c5ae
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 1, 2019
…/saltfs#508 (comment) (from Manishearth:resync-yml); r=aneeshusa

r? aneeshusa

Source-Repo: https://github.com/servo/servo
Source-Revision: 4034bd68c2b2b9b899ecfb6e0d2b3ba17109c5ae

UltraBlame original commit: 9c339f7972bad5b87662d79c3612ec644c142cd4
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 1, 2019
…/saltfs#508 (comment) (from Manishearth:resync-yml); r=aneeshusa

r? aneeshusa

Source-Repo: https://github.com/servo/servo
Source-Revision: 4034bd68c2b2b9b899ecfb6e0d2b3ba17109c5ae

UltraBlame original commit: 9c339f7972bad5b87662d79c3612ec644c142cd4
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 1, 2019
…/saltfs#508 (comment) (from Manishearth:resync-yml); r=aneeshusa

r? aneeshusa

Source-Repo: https://github.com/servo/servo
Source-Revision: 4034bd68c2b2b9b899ecfb6e0d2b3ba17109c5ae

UltraBlame original commit: 9c339f7972bad5b87662d79c3612ec644c142cd4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.