Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove steps.yml from saltfs #513

Closed
wants to merge 1 commit into from
Closed

Conversation

@aneeshusa
Copy link
Member

aneeshusa commented Oct 19, 2016

These now live in the main servo/servo repo.

r? @larsbergstrom
I'd like to have at least one PR build + be merged with the new configuration before removing the steps in case we need to revert/quickfix.


This change is Reviewable

These now live in the main servo/servo repo.
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Oct 19, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Oct 19, 2016

📌 Commit 21da33f has been approved by larsbergstrom

@bors-servo
Copy link
Contributor

bors-servo commented Oct 19, 2016

Testing commit 21da33f with merge 28b5b42...

bors-servo added a commit that referenced this pull request Oct 19, 2016
Remove steps.yml from saltfs

These now live in the main servo/servo repo.

r? @larsbergstrom
I'd like to have at least one PR build + be merged with the new configuration before removing the steps in case we need to revert/quickfix.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/513)
<!-- Reviewable:end -->
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Oct 19, 2016

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Oct 19, 2016

(Just noticed that we don't have a PR pending - I assumed ONE must have gone through since I rolled out the changes, but was wrong...)

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Oct 19, 2016

Hrm, yeah, there's a failure, but just on windows-dev:
http://build.servo.org/builders/windows-dev/builds/1568

@bors-servo
Copy link
Contributor

bors-servo commented Oct 19, 2016

☀️ Test successful - status-travis

@aneeshusa
Copy link
Member Author

aneeshusa commented Oct 29, 2016

Taken care of in #522.

@aneeshusa aneeshusa closed this Oct 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.