Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRevert the DynamicServoFactory stuff #515
Merged
+162
−13
Conversation
|
Can you leave the "Fix steps reading on windows" commit for now? I want to spin up a |
larsbergstrom
force-pushed the
larsbergstrom:revert_stuff
branch
from
de05332
to
ca53f31
|
Done! |
|
@bors-servo r+ I have some ideas about the new Windows failures - expect more PRs soon. |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 20, 2016
Revert the DynamicServoFactory stuff r? @aneeshusa I need to just revert it all until we can sort out what's going on. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/515) <!-- Reviewable:end -->
|
Passed on all but mac; merging :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
larsbergstrom commentedOct 20, 2016
•
edited
r? @aneeshusa
I need to just revert it all until we can sort out what's going on.
This change is