Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove old DynamicServoFactory which reads from saltfs #522
Conversation
Now that the new dynamic factory is working (which reads the steps configuration from the main servo repo), remove the old one, and remove the steps.yml file from this repo as well. However, re-use the old name (DynamicServoFactory instead of DynamicServoYAMLFactory) for concision and clarity.
|
@bors-servo r+ |
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 27, 2016
…, r=larsbergstrom Remove old DynamicServoFactory which reads from saltfs Now that the new dynamic factory is working (which reads the steps configuration from the main servo repo), remove the old one, and remove the steps.yml file from this repo as well. However, re-use the old name (DynamicServoFactory instead of DynamicServoYAMLFactory) for concision and clarity. `windows-dev-yaml` is [now working](http://build.servo.org/builders/windows-dev-yaml) after #517! r? @larsbergstrom <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/522) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedOct 27, 2016
•
edited by larsbergstrom
Now that the new dynamic factory is working (which reads the steps
configuration from the main servo repo), remove the old one,
and remove the steps.yml file from this repo as well.
However, re-use the old name (DynamicServoFactory instead of
DynamicServoYAMLFactory) for concision and clarity.
windows-dev-yamlis now working after #517! r? @larsbergstromThis change is