Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upEnsure dynamic Buildbot steps have unique names #525
Merged
Conversation
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 28, 2016
…jack Ensure dynamic Buildbot steps have unique names Buildbot requires that each step in a build has a unique name, and uses this property to e.g. disambiguate log files. By default, each step's name reflect what kind of step it is, e.g. `git` or `test`. Add count suffixes to the end of the step name if there are multiple steps of the same type to disambiguate them. (Buildbot already does this internally for steps added statically in the `setupBuild` method). This requires checking all previously-added steps for name collisions, so add all the steps at one time to amortize this cost. Fixes #524. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/525) <!-- Reviewable:end -->
|
|
Buildbot requires that each step in a build has a unique name, and uses this property to e.g. disambiguate log files. By default, each step's name reflect what kind of step it is, e.g. `git` or `test`. Add count suffixes to the end of the step name if there are multiple steps of the same type to disambiguate them. (Buildbot already does this internally for steps added statically in the `setupBuild` method). This requires checking all previously-added steps for name collisions, so add all the steps at one time to amortize this cost.
aneeshusa
force-pushed the
aneeshusa:ensure-steps-have-unique-names
branch
from
6624612
to
90b3c4f
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 28, 2016
…bergstrom Ensure dynamic Buildbot steps have unique names Buildbot requires that each step in a build has a unique name, and uses this property to e.g. disambiguate log files. By default, each step's name reflect what kind of step it is, e.g. `git` or `test`. Add count suffixes to the end of the step name if there are multiple steps of the same type to disambiguate them. (Buildbot already does this internally for steps added statically in the `setupBuild` method). This requires checking all previously-added steps for name collisions, so add all the steps at one time to amortize this cost. Fixes #524. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/525) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedOct 28, 2016
•
edited by larsbergstrom
Buildbot requires that each step in a build has a unique name,
and uses this property to e.g. disambiguate log files.
By default, each step's name reflect what kind of step it is,
e.g.
gitortest.Add count suffixes to the end of the step name if there are
multiple steps of the same type to disambiguate them.
(Buildbot already does this internally for steps added statically
in the
setupBuildmethod).This requires checking all previously-added steps for name collisions,
so add all the steps at one time to amortize this cost.
Fixes #524.
This change is