Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re provide homebrew upload token #533

Merged
merged 2 commits into from Oct 31, 2016
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Prev

Re-add logic to provide Homebrew upload token

This was added to the previous `make_step` implementation,
but apparently was not copied over to this implementation,
causing our Homebrew uploads to fail for the last 4 days.
Re-add this logic.

Note that because adding the token to the environment and telling
Buildbot not to log the environment are configured together,
the token was not leaked during this time.
  • Loading branch information
aneeshusa committed Oct 31, 2016
commit 37f946f7f05aebf85d7eeadda9eb7a29c31ff4ec
@@ -195,6 +195,11 @@ def make_step(self, command):
r'C:\Program Files\Amazon\cfn-bootstrap',
])

# Set token for homebrew repository
elif arg == './etc/ci/update_brew.sh':
step_kwargs['logEnviron'] = False
step_env += envs.update_brew

else:
step_desc += [arg]

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.