Export Windows Python on Windows builders #537
+4
−2
Export Windows Python on Windows builders
- Loading branch information
commit 7790a8ce1e7961c92d1bf4923201e3d409021477
| @@ -176,9 +176,11 @@ def make_step(self, command): | ||
|
|
||
| command = command.split(' ') | ||
|
|
||
| # Add `bash -l` before every command on Windows builders | ||
| bash_args = ["bash", "-l"] if self.is_windows else [] | ||
| step_kwargs['command'] = bash_args + command | ||
| # Add `bash -l -c` and export Windows Python before every command | ||
| # on Windows builders | ||
| bash_args = "export PATH=/c/python27:/c/python27/scripts:$PATH; " | ||
|
||
| command_win = ["bash", "-l", "-c", bash_args + " ".join(command)] | ||
| step_kwargs['command'] = command_win if self.is_windows else command | ||
|
||
| if self.is_windows: | ||
| step_env += envs.Environment({ | ||
| # Set home directory, to avoid adding `cd` command every time | ||
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
We have an
Environmentclass which makes it easy to add things to environment. Is there some reason you can't updatestep_envinstead (i.e. does the environment not get inherited through bash)?