Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update_brew doesn't exist anymore #541

Merged
merged 1 commit into from Dec 29, 2016
Merged

update_brew doesn't exist anymore #541

merged 1 commit into from Dec 29, 2016

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Nov 29, 2016 •
edited by larsbergstrom

follow up servo/servo#14403

This change is Reviewable
@aneeshusa
Copy link
Member

aneeshusa commented Dec 7, 2016

We'll need to pass the token to the upload_nightly.sh script instead. Best way is to move the token into the upload_nightly Environment in environments.py.

Normally we would copy the token to both places, then remove the old copy after removing update_brew.sh, but since it's currently busted anyways I think we can skip that.
@paulrouget
update_brew doesn't exist anymore
Loading status checks…
6cedde3
@paulrouget paulrouget force-pushed the fixBrew branch from dd0b623 to 6cedde3 Dec 13, 2016
@aneeshusa
Copy link
Member

aneeshusa commented Dec 29, 2016

Didn't see you had updated this, LGTM. @bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 29, 2016

📌 Commit 6cedde3 has been approved by aneeshusa
@bors-servo
Copy link
Contributor

bors-servo commented Dec 29, 2016

⌛ Testing commit 6cedde3 with merge 5c911be...
bors-servo added a commit that referenced this pull request Dec 29, 2016
@bors-servo
Auto merge of #541 - servo:fixBrew, r=aneeshusa
Loading status checks…
5c911be 
update_brew doesn't exist anymore

follow up servo/servo#14403

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/541)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 29, 2016

☀️ Test successful - status-travis
@bors-servo bors-servo merged commit 6cedde3 into master Dec 29, 2016
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
homu Test successful
Details
@aneeshusa aneeshusa mentioned this pull request Jan 10, 2017
Closed
@SimonSapin SimonSapin deleted the fixBrew branch Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aneeshusa aneeshusa

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@paulrouget @aneeshusa @bors-servo @highfive
You can’t perform that action at this time.