Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uppin python 2.7.9 to make SNI work #542
Closed
Conversation
|
Checked this in Vagrant and looks overall, just one nit. Please update the commit message to be more descriptive/add a bit more exposition and this is good to go. |
| @@ -1,4 +1,3 @@ | |||
|
|
|||
This comment has been minimized.
This comment has been minimized.
aneeshusa
Dec 7, 2016
Member
I believe the .tac files are generated by Buildbot, so I would prefer to leave them untouched.
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
edunham commentedNov 29, 2016
•
edited by larsbergstrom
see http://stackoverflow.com/questions/18578439/using-requests-with-tls-doesnt-give-sni-support/18579484#18579484 for more info but really it's the Right Thing to make sure all the builders are on the same python version anyways
This change is