Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-broken hash for Salt fileserver cache checking #546

Merged
merged 1 commit into from Dec 23, 2016
Merged

Use non-broken hash for Salt fileserver cache checking #546

merged 1 commit into from Dec 23, 2016

Conversation

@aneeshusa
Copy link
Member

aneeshusa commented Dec 7, 2016 •
edited by larsbergstrom

The default is md5, so upgrade to a better hash.

This change is Reviewable
@aneeshusa
Copy link
Member Author

aneeshusa commented Dec 7, 2016

FYI, this will require a manual salt-master restart after deployment; make sure to clean out the Salt master cache (/var/cache/salt/master I believe) when restarting as well to get rid of old md5 hashes.
@aneeshusa
Copy link
Member Author

aneeshusa commented Dec 23, 2016

r? @larsbergstrom
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Dec 23, 2016

I think you might need to rebase to pick up the newer intermittent tracker thing? The Travis stuff failed. After that, r=me :-)
@aneeshusa
Use non-broken hash for Salt fileserver cache checking
Loading status checks…
cc7afd3 
The default is md5, so upgrade to a better hash.
@aneeshusa aneeshusa force-pushed the aneeshusa:use-better-hash-for-salt-fileserver-caching branch from 2c871a6 to cc7afd3 Dec 23, 2016
@aneeshusa
Copy link
Member Author

aneeshusa commented Dec 23, 2016

It shouldn't matter since homu will test after merging into master, but rebased anyways. @bors-servo r=larsbergstrom
@bors-servo
Copy link
Contributor

bors-servo commented Dec 23, 2016

📌 Commit cc7afd3 has been approved by larsbergstrom
@bors-servo
Copy link
Contributor

bors-servo commented Dec 23, 2016

⌛ Testing commit cc7afd3 with merge 51c23cb...
bors-servo added a commit that referenced this pull request Dec 23, 2016
@bors-servo
Auto merge of #546 - aneeshusa:use-better-hash-for-salt-fileserver-ca…
Loading status checks…
51c23cb 
…ching, r=larsbergstrom

Use non-broken hash for Salt fileserver cache checking

The default is md5, so upgrade to a better hash.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/546)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 23, 2016

☀️ Test successful - status-travis
@bors-servo bors-servo merged commit cc7afd3 into servo:master Dec 23, 2016
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Dec 23, 2016
Merged
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Dec 23, 2016

This has been deployed, the cache obliterated, and logs checked to ensure that after a restart teh salt-master service still appeared to be running.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@larsbergstrom larsbergstrom

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@aneeshusa @larsbergstrom @bors-servo @highfive
You can’t perform that action at this time.