Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upEnable unlimited Salt job logging #547
Merged
Conversation
|
Same as other, r=me after rebase so that it has the non-broken intermittent tracker revision :-) Thanks! |
|
|
Add some docs in tree as well about this feature, to avoid forgetting to update the wiki when the PR lands.
aneeshusa
force-pushed the
aneeshusa:enable-unlimited-job-logging
branch
from
ff56d2a
to
b7c88c7
|
@bors-servo r=larsbergstrom |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 23, 2016
…rgstrom Enable unlimited Salt job logging Add some docs in tree as well about this feature, to avoid forgetting to update the wiki when the PR lands. This is a potential (partial?) fix for #437, with two caveats: - I'm not sure of a way to "tag" a highstate deployment with the revision/PR being deployed; we'll still need to keep track of that manually - The `keep_jobs` config option is a number of hours (the default is 24), so we can set it a concrete number instead of 0 for unlimited if you'd like. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/547) <!-- Reviewable:end -->
Closed
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedDec 7, 2016
•
edited by larsbergstrom
Add some docs in tree as well about this feature,
to avoid forgetting to update the wiki when the PR lands.
This is a potential (partial?) fix for #437, with two caveats:
keep_jobsconfig option is a number of hours (the default is 24), so we can set it a concrete number instead of 0 for unlimited if you'd like.This change is