Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake CheckRevisionStep Twisted-compatible #554
Merged
Conversation
The inlineCallbacks decorator requires that the function it wraps (here, the run() method of CheckRevisionStep) is a generator, so that is is able to suspend execution to require it to insert callbacks. Make run() into a generator by yielding the Deferred return value.
|
Fixes #553; r? @larsbergstrom |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 13, 2016
…atible, r=larsbergstrom Make CheckRevisionStep Twisted-compatible The inlineCallbacks decorator requires that the function it wraps (here, the run() method of CheckRevisionStep) is a generator, so that is is able to suspend execution to require it to insert callbacks. Make run() into a generator by yielding the Deferred return value. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/554) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedDec 13, 2016
•
edited by larsbergstrom
The inlineCallbacks decorator requires that the function it wraps
(here, the run() method of CheckRevisionStep) is a generator, so that
is is able to suspend execution to require it to insert callbacks.
Make run() into a generator by yielding the Deferred return value.
This change is