New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use UTC timezone #569
Merged
+37
−0
Merged
Use UTC timezone #569
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.
No changes.
| @@ -0,0 +1,18 @@ | ||
| import subprocess | ||
|
|
||
| from tests.util import Failure, Success | ||
|
|
||
|
|
||
| def run(): | ||
| ret = subprocess.run( | ||
| ['date'], | ||
| stdout=subprocess.PIPE, | ||
| stderr=subprocess.PIPE | ||
| ) | ||
|
|
||
| stdout = ret.stdout.decode('utf-8') | ||
|
|
||
| if ret.returncode == 0 and 'UTC' in stdout: | ||
| return Success('Date is in UTC') | ||
charlesvdv
Author
Contributor
|
||
| else: | ||
| return Failure('Date is not in UTC: ', stdout) | ||
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I was reading an article about testing yesterday which reminded me of expected-failure tests, which is IMO a nicer way to handle the macOS situtation. Roughly, instead of just returning
Successhere, usesys.platformto check if we're on macOS, and if so, returnFailurein that case with an appropriate message; and vice-versa for theFailure. This inverts the expectations and lets us run thesls.commontest unconditionally.Note that in the .travis.yml file, I believe
pythonisn't supported on macOS, so don't update those entries to add the python3.5 spec. However, we may need to install Python 3.5 manually withbrewon the OS X builders; make a separate commit and see if it's necessary before adding that.It may be a little tricky to add so I'll make it optional, for bonus points :)