Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upQuote repo names to ensure valid TOML #580
Merged
Conversation
Otherwise repos like `download.servo.org` which contain dots in their name are not parsed correctly; using quotes ensures the repo name is parsed as a single string.
|
Unless the repo name contains a |
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 22, 2017
Quote repo names to ensure valid TOML Otherwise repos like `download.servo.org` which contain dots in their name are not parsed correctly; using quotes ensures the repo name is parsed as a single string. Discovered while trying to merge servo/download.servo.org#16. I have little TOML experience, so I'm not sure if this actually works or will break our `cfg.toml` entirely. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/580) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedJan 22, 2017
•
edited by larsbergstrom
Otherwise repos like
download.servo.orgwhich contain dots in their name are not parsed correctly;
using quotes ensures the repo name is parsed as a single string.
Discovered while trying to merge servo/download.servo.org#16.
I have little TOML experience, so I'm not sure if this actually works or will break our
cfg.tomlentirely.This change is