Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an up-to-date llvm. #582

Merged
merged 1 commit into from Jan 22, 2017
Merged

Use an up-to-date llvm. #582

merged 1 commit into from Jan 22, 2017

Conversation

@emilio
Copy link
Member

emilio commented Jan 22, 2017 •
edited by larsbergstrom

This allows us to update OsMesa, see:

Please wait for ci, since I don't have any Debian-based system.

This change is Reviewable
@aneeshusa
Copy link
Member

aneeshusa commented Jan 22, 2017

FYI, you can use Vagrant to test locally, although we also test the Salt configs on Travis.

Is this blocked on the other two PRs or standalone? Changes LGTM either way, so r=me when this is ready.
@aneeshusa aneeshusa mentioned this pull request Jan 22, 2017
Closed
@emilio
Copy link
Member Author

emilio commented Jan 22, 2017

This is standalone, the other two PRs are blocked on this one.

Thanks for reviewing this @aneeshusa! :)
@aneeshusa
Copy link
Member

aneeshusa commented Jan 22, 2017 •
edited

FYI, I don't think llvm-3.8-dev is available in the default repos for Trusty (14.04), although llvm-3.5-dev (via security) and llvm-3.4-dev should be.
@emilio
Copy link
Member Author

emilio commented Jan 22, 2017

Those should definitely be enough. Travis builds seem green, though I think they use a newer distro version?

Anyway, 3.5 should be enough, so will change to that.
@emilio emilio force-pushed the emilio:llvm branch from 7bd47cd to 72dd9b3 Jan 22, 2017
@emilio
Use an (slightly more) up-to-date llvm.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
fbb642b 
This allows us to update OsMesa, see:

 * servo/osmesa-src#15
 * servo/servo#14584
@emilio emilio force-pushed the emilio:llvm branch from 72dd9b3 to fbb642b Jan 22, 2017
@emilio
Copy link
Member Author

emilio commented Jan 22, 2017

@bors-servo r=aneeshusa
@bors-servo
Copy link
Contributor

bors-servo commented Jan 22, 2017

📌 Commit fbb642b has been approved by aneeshusa
@bors-servo
Copy link
Contributor

bors-servo commented Jan 22, 2017

⌛ Testing commit fbb642b with merge 21862bc...
bors-servo added a commit that referenced this pull request Jan 22, 2017
@bors-servo
Auto merge of #582 - emilio:llvm, r=aneeshusa
Loading status checks…
21862bc 
Use an up-to-date llvm.

This allows us to update OsMesa, see:

 * servo/osmesa-src#15
 * servo/servo#14584

Please wait for ci, since I don't have any Debian-based system.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/582)
<!-- Reviewable:end -->
@aneeshusa
Copy link
Member

aneeshusa commented Jan 22, 2017

Travis doesn't use the standard sources lists I believe, see #417, so it might be adding some extra repos. We're using Trusty for now on Travis, as Xenial isn't supported yet, see my latest comment at #462.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 22, 2017

☀️ Test successful - status-travis
@bors-servo bors-servo merged commit fbb642b into servo:master Jan 22, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@aneeshusa aneeshusa mentioned this pull request Jan 22, 2017
Merged
@larsbergstrom larsbergstrom mentioned this pull request Feb 2, 2017
Merged
@emilio emilio deleted the emilio:llvm branch Feb 2, 2017
@choudhary001 choudhary001 mentioned this pull request Mar 14, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aneeshusa aneeshusa

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@emilio @aneeshusa @bors-servo @highfive
You can’t perform that action at this time.