Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional reviewers to webrender repositories #590

Closed
wants to merge 2 commits into from
Closed

Conversation

@jdm
Copy link
Member

jdm commented Jan 30, 2017

This seems like the state of the world right now.


This change is Reviewable

},
{
"name": "webrender_traits"
"name": "webrender_traits",
"extra_reviewers": [ "jrmuizel", "vvuk" ]

This comment has been minimized.

@emilio

emilio Jan 30, 2017

Member

This is probably useless because wr-traits now effectively lives in the wr repo.

@emilio
Copy link
Member

emilio commented Feb 2, 2017

I'd approve this myself, but I think I can't, so maybe r? @glennw

@glennw
Copy link
Member

glennw commented Feb 13, 2017

@KiChjang
Copy link
Member

KiChjang commented Feb 13, 2017

@bors-servo are you still there?

@bors-servo
Copy link
Contributor

bors-servo commented May 17, 2017

The latest upstream changes (presumably #605) made this pull request unmergeable. Please resolve the merge conflicts.

bors-servo added a commit that referenced this pull request May 17, 2017
Add jrmuizel as a webrender reviewer

Rebase of #590.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/669)
<!-- Reviewable:end -->
@jdm
Copy link
Member Author

jdm commented May 17, 2017

Rebased in #669.

@jdm jdm closed this May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.