New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give Xidorn reviewer privileges. #594

Merged
merged 1 commit into from Feb 2, 2017

Conversation

Projects
None yet
6 participants
@emilio
Member

emilio commented Feb 2, 2017

He has been doing a bunch of reviews and triaging both in Servo and in Bindgen,
and I'm tired of landing the patches he reviews :P


This change is Reviewable

Give Xidorn reviewer privileges.
He has been doing a bunch of reviews and triaging both in Servo and in Bindgen,
and I'm tired of landing the patches he reviews ;).
@emilio

This comment has been minimized.

Show comment
Hide comment
@emilio

emilio Feb 2, 2017

Member

r? @jdm (or anybody else that can approve this?)

cc @upsuper

Member

emilio commented Feb 2, 2017

r? @jdm (or anybody else that can approve this?)

cc @upsuper

@highfive highfive assigned jdm and unassigned aneeshusa Feb 2, 2017

@upsuper

This comment has been minimized.

Show comment
Hide comment
@upsuper

upsuper Feb 2, 2017

Member

Thanks :)

Member

upsuper commented Feb 2, 2017

Thanks :)

@jdm

This comment has been minimized.

Show comment
Hide comment
@jdm

jdm Feb 2, 2017

Member

@bors-servo: r+
Congratulations!

Member

jdm commented Feb 2, 2017

@bors-servo: r+
Congratulations!

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 2, 2017

Contributor

📌 Commit 62f1343 has been approved by jdm

Contributor

bors-servo commented Feb 2, 2017

📌 Commit 62f1343 has been approved by jdm

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 2, 2017

Contributor

⌛️ Testing commit 62f1343 with merge 5bc2be2...

Contributor

bors-servo commented Feb 2, 2017

⌛️ Testing commit 62f1343 with merge 5bc2be2...

bors-servo added a commit that referenced this pull request Feb 2, 2017

Auto merge of #594 - emilio:xidorn, r=jdm
Give Xidorn reviewer privileges.

He has been doing a bunch of reviews and triaging both in Servo and in Bindgen,
and I'm tired of landing the patches he reviews :P

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/594)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 2, 2017

Contributor

☀️ Test successful - status-travis
Approved by: jdm
Pushing 5bc2be2 to master...

Contributor

bors-servo commented Feb 2, 2017

☀️ Test successful - status-travis
Approved by: jdm
Pushing 5bc2be2 to master...

@bors-servo bors-servo merged commit 62f1343 into servo:master Feb 2, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment