Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notify travis status in servo-bots channel #598

Merged
merged 1 commit into from Feb 10, 2017
Merged

Conversation

@edunham
Copy link
Contributor

edunham commented Feb 9, 2017

this is the other half of fixing #376

i have already turned on nightly builds via travis's experimental cron feature


This change is Reviewable

@aneeshusa
Copy link
Member

aneeshusa commented Feb 9, 2017

What is the #servo-bots channel? Is there someone (a human) monitoring this so we find out about failed nightly builds?

@edunham
Copy link
Contributor Author

edunham commented Feb 9, 2017

#servo-bots is a channel where all of Servo's bots dump information, so that we can use our IRC clients to filter those notifications which we care about. Jack and I idle in there, and others are welcome to as well.

Dropping notifications into the bots channel basically just makes it easy to "subscribe" to whatever subset of notifications we each find relevant, while making sure we don't clutter the channels which exist for human conversation.

@aneeshusa
Copy link
Member

aneeshusa commented Feb 9, 2017

OK, the only other suggestion I had was maybe using on_success and on_failure to pre-filter which notifications Travis sends to IRC, but if you're filtering in your client it's not necessary. r=me with or without that.

@edunham
Copy link
Contributor Author

edunham commented Feb 9, 2017

@bors-servo r=aneeshusa

@bors-servo
Copy link
Contributor

bors-servo commented Feb 9, 2017

📌 Commit b4adc55 has been approved by aneeshusa

@bors-servo
Copy link
Contributor

bors-servo commented Feb 9, 2017

Testing commit b4adc55 with merge 8c9aa37...

bors-servo added a commit that referenced this pull request Feb 9, 2017
notify travis status in servo-bots channel

this is the other half of fixing #376

i have already turned on nightly builds via travis's experimental cron feature

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/598)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 10, 2017

☀️ Test successful - status-travis
Approved by: aneeshusa
Pushing 8c9aa37 to master...

@bors-servo bors-servo merged commit b4adc55 into servo:master Feb 10, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.