Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upTry pinning to a Twisted version that worked #604
Merged
Conversation
So Twisted 17.1.0 came out right when https://travis-ci.org/servo/saltfs/jobs/201390958 failure started happening, as Aneesh noted in #601
|
r? @Manishearth This should put the nightly build back in order |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 15, 2017
Try pinning to a Twisted version that worked So Twisted 17.1.0 came out right when https://travis-ci.org/servo/saltfs/jobs/201390958 failure started happening, as Aneesh noted in #601 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/604) <!-- Reviewable:end -->
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 15, 2017
…rsbergstrom Pin Twisted version for builders I was following up on #588 and saw that a `servo-linux-cross3` machine has been provisioned, but the buildmaster doesn't know about it. Checking the logs, it appears that the buildbot-slave service doesn't start successfully, and the stack trace seems to be the same reason as #601 (comment), namely a version of Twisted that is too new. This PR is similar to #604, but pins the Twisted version for builders instead of the buildmaster. I also included some more requisites. This should fix #588 once deployed. r? @edunham @larsbergstrom <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/630) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this pull request
Apr 21, 2017
…rsbergstrom Pin Twisted version for builders I was following up on #588 and saw that a `servo-linux-cross3` machine has been provisioned, but the buildmaster doesn't know about it. Checking the logs, it appears that the buildbot-slave service doesn't start successfully, and the stack trace seems to be the same reason as #601 (comment), namely a version of Twisted that is too new. This PR is similar to #604, but pins the Twisted version for builders instead of the buildmaster. I also included some more requisites. This should fix #588 once deployed. r? @edunham @larsbergstrom <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/630) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
edunham commentedFeb 14, 2017
•
edited by larsbergstrom
So Twisted 17.1.0 came out right when
https://travis-ci.org/servo/saltfs/jobs/201390958 failure started happening,
as Aneesh noted in #601
This change is