Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upChange steps.Git(… method="fresh") to method="clean" #611
Conversation
http://docs.buildbot.net/latest/manual/cfg-buildsteps.html#git This will keep the `target` directory between builds, and hopefully reduce build times since not every build will need to recompile everything.
highfive
commented
Mar 3, 2017
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @aneeshusa (or someone else) soon. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 3, 2017
Change steps.Git(… method="fresh") to method="clean" http://docs.buildbot.net/latest/manual/cfg-buildsteps.html#git This will keep the `target` directory between builds, and hopefully reduce build times since not every build will need to recompile everything. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/611) <!-- Reviewable:end -->
|
|
|
@metajack Was this deployed? Recent builds are still running |
|
I did the deploy, but perhaps the buildbots don't restart automatically? I will try and confirm. |
|
Looks good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SimonSapin commentedMar 3, 2017
•
edited by larsbergstrom
http://docs.buildbot.net/latest/manual/cfg-buildsteps.html#git
This will keep the
targetdirectory between builds, and hopefully reduce build times since not every build will need to recompile everything.This change is