Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd Diane and Canaltinova to reviewers #616
Merged
Conversation
|
r? @metajack or @larsbergstrom or @jdm |
|
For documentation, can you post some of the PRs @canaltinova has reviewed? |
|
Yes, it began with servo/servo#13886, servo/servo#14271 and now, everything else here - https://github.com/servo/servo/pulls?q=is%3Apr+assignee%3Acanaltinova+is%3Aclosed |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 14, 2017
Add Diane and Canaltinova to reviewers @avadacatavra is a Mozilla employee (she's reviewed servo/servo#15889 and servo/servo#15783, and possibly more in the future). And, @canaltinova has reviewed various PRs, have filed a number of issues for newcomers, and is a frequent contributor to servo. I think we can move both of them to reviewers list. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/616) <!-- Reviewable:end -->
|
@bors-servo ping |
|
|
|
@bors-servo r+ clean retry |
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 14, 2017
Add Diane and Canaltinova to reviewers @avadacatavra is a Mozilla employee (she's reviewed servo/servo#15889 and servo/servo#15783, and possibly more in the future). And, @canaltinova has reviewed various PRs, have filed a number of issues for newcomers, and is a frequent contributor to servo. I think we can move both of them to reviewers list. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/616) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
wafflespeanut commentedMar 10, 2017
•
edited
@avadacatavra is a Mozilla employee (she's reviewed servo/servo#15889 and servo/servo#15783, and possibly more in the future). And, @canaltinova has reviewed various PRs, have filed a number of issues for newcomers, and is a frequent contributor to servo. I think we can move both of them to reviewers list.
This change is