Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove windows-gnu-dev builds #620
Merged
Conversation
|
r? @metajack |
|
We are currently deprecating these builds, as discussed with @metajack. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 15, 2017
Remove windows-gnu-dev builds <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/620) <!-- Reviewable:end -->
|
|
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Apr 15, 2017
Remove windows-gnu build code <!-- Please describe your changes on the following line: --> This is a follow-up to servo/saltfs#620. There are three other places `windows-gnu` is mentioned, I'm not sure if they can also be removed or not: - `nightly-x86_64-pc-windows-gnu` is listed as a target in the `appveyor.yml` build matrix - 2 uses inside `host_platform` in `python/servo/util.py` - The `windows_gnu` bootstrapper in `python/servo/bootstrap.py` --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they remove unused code <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16468) <!-- Reviewable:end -->
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 15, 2017
…emove-windows-gnu); r=metajack <!-- Please describe your changes on the following line: --> This is a follow-up to servo/saltfs#620. There are three other places `windows-gnu` is mentioned, I'm not sure if they can also be removed or not: - `nightly-x86_64-pc-windows-gnu` is listed as a target in the `appveyor.yml` build matrix - 2 uses inside `host_platform` in `python/servo/util.py` - The `windows_gnu` bootstrapper in `python/servo/bootstrap.py` --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they remove unused code <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 7ae9c96467b1a80f104aa5346c9fd11522490541 --HG-- extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear extra : subtree_revision : 8e1b943fe6b0dc1bed06d58fcb3aa6d67d51271a
Manishearth
pushed a commit
to Manishearth/gecko-dev
that referenced
this pull request
Apr 21, 2017
…emove-windows-gnu); r=metajack <!-- Please describe your changes on the following line: --> This is a follow-up to servo/saltfs#620. There are three other places `windows-gnu` is mentioned, I'm not sure if they can also be removed or not: - `nightly-x86_64-pc-windows-gnu` is listed as a target in the `appveyor.yml` build matrix - 2 uses inside `host_platform` in `python/servo/util.py` - The `windows_gnu` bootstrapper in `python/servo/bootstrap.py` --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they remove unused code <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 7ae9c96467b1a80f104aa5346c9fd11522490541
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 1, 2019
…emove-windows-gnu); r=metajack <!-- Please describe your changes on the following line: --> This is a follow-up to servo/saltfs#620. There are three other places `windows-gnu` is mentioned, I'm not sure if they can also be removed or not: - `nightly-x86_64-pc-windows-gnu` is listed as a target in the `appveyor.yml` build matrix - 2 uses inside `host_platform` in `python/servo/util.py` - The `windows_gnu` bootstrapper in `python/servo/bootstrap.py` --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they remove unused code <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 7ae9c96467b1a80f104aa5346c9fd11522490541 UltraBlame original commit: 059d96b87f6d0f65d062c4a2589454f197184c6d
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
…emove-windows-gnu); r=metajack <!-- Please describe your changes on the following line: --> This is a follow-up to servo/saltfs#620. There are three other places `windows-gnu` is mentioned, I'm not sure if they can also be removed or not: - `nightly-x86_64-pc-windows-gnu` is listed as a target in the `appveyor.yml` build matrix - 2 uses inside `host_platform` in `python/servo/util.py` - The `windows_gnu` bootstrapper in `python/servo/bootstrap.py` --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they remove unused code <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 7ae9c96467b1a80f104aa5346c9fd11522490541 UltraBlame original commit: 059d96b87f6d0f65d062c4a2589454f197184c6d
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
…emove-windows-gnu); r=metajack <!-- Please describe your changes on the following line: --> This is a follow-up to servo/saltfs#620. There are three other places `windows-gnu` is mentioned, I'm not sure if they can also be removed or not: - `nightly-x86_64-pc-windows-gnu` is listed as a target in the `appveyor.yml` build matrix - 2 uses inside `host_platform` in `python/servo/util.py` - The `windows_gnu` bootstrapper in `python/servo/bootstrap.py` --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they remove unused code <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 7ae9c96467b1a80f104aa5346c9fd11522490541 UltraBlame original commit: 059d96b87f6d0f65d062c4a2589454f197184c6d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nox commentedMar 15, 2017
•
edited by larsbergstrom
This change is