Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd clang dependency required for rust-bindgen #626
Merged
+2
−0
Conversation
highfive
commented
Mar 22, 2017
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @aneeshusa (or someone else) soon. |
|
clang-3.5 should be enough for now (right @emilio ?) We can update to clang-3.8 when the 16.04 based machines are ready: cc @larsbergstrom @fabricedesre @metajack |
|
@bors-servo r+ |
|
@bors-servo: ping |
|
@bors-servo: r=aneeshusa |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 11, 2017
Add clang dependency required for rust-bindgen This allows us to use crates which depend on rust-bindgen. Required for servo/servo#16059. There are more rust-bindgen based dependencies coming soon (https://crates.io/crates/gvr-sys) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/626) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
MortimerGoro commentedMar 22, 2017
•
edited by larsbergstrom
This allows us to use crates which depend on rust-bindgen.
Required for servo/servo#16059. There are more rust-bindgen based dependencies coming soon (https://crates.io/crates/gvr-sys)
This change is