Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up taking a GitHub access token #627

Closed
wants to merge 1 commit into from

Conversation

edunham
Copy link
Contributor

@edunham edunham commented Mar 23, 2017

Duct tape fix to #606. I have created a token with no special perms from my account and stuck it in the appropriate slot in the Travis UI to expose it as an env var to this repo's builds. We can change the contents of that env var through the UI at any time so it'll be easy enough to switch it to a token with different scopes, and eventually to one on Homu's account, in the process of debugging this.


This change is Reviewable

@aneeshusa
Copy link
Contributor

Closing in favor of an approach that uses HEAD requests to GitHub to query repo existence, which shouldn't require a token, as mentioned in my review. If we ever update the test to also check the configured webhooks, we can set up a token at that point.

@aneeshusa aneeshusa closed this Apr 11, 2017
@aneeshusa
Copy link
Contributor

Oh, I see this is to get around rate-limiting instead, we'll probably need this.

@aneeshusa aneeshusa reopened this Apr 11, 2017
@aneeshusa
Copy link
Contributor

Instead of conflating this with Homu's GitHub access token, I would prefer to have a separate token for the test suite to use when making requests to GitHub. This means we can use the environment variable directly and don't have to sneak it through Salt.

@aneeshusa
Copy link
Contributor

Also, it seems like Travis doesn't like the existing token either and complains that it is malformed: https://travis-ci.org/servo/saltfs/jobs/221121527

@aneeshusa
Copy link
Contributor

We didn't need a token for #606 (just used HEAD requests); we can revisit this later if needed.

@aneeshusa aneeshusa closed this May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants