Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse openjdk-r PPA for OpenJDK8 on Ubuntu 14.04 #629
Merged
Conversation
This was referenced Apr 11, 2017
|
I'm testing this locally to ensure that the package is successfully installed (the logs on travis are not typically super verbose). |
|
Yeah, I also believe Travis enables some extra PPAs on their builders which is why #617 passed on Travis even though it isn't working on our builders. I used the |
|
Confirmed this works in a local @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 11, 2017
…ergstrom Use openjdk-r PPA for OpenJDK8 on Ubuntu 14.04 This makes #617 work properly by using the openjdk-r PPA for the OpenJDK 8 packages. r? @larsbergstrom cc @fabricedesre <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/629) <!-- Reviewable:end -->
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 18, 2017
Set JAVA_HOME env var to OpenJDK 8 for Android builds The new gradle builds require Java 8, and the existing ant builds also work with Java 8. This is easier than running many `update-alternatives` calls from Salt. Moreover, this allows keeping Java 7 installed together with Java 8. Needed for servo/servo#15773. Follow-up to to #617 and #629. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/638) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedApr 11, 2017
•
edited by larsbergstrom
This makes #617 work properly by using the openjdk-r PPA for the OpenJDK 8 packages.
r? @larsbergstrom
cc @fabricedesre
This change is