Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWIP: Add mach bootstrap test #631
Closed
+127
−70
Conversation
aneeshusa
force-pushed the
aneeshusa:add-mach-bootstrap-test
branch
3 times, most recently
from
2c5e826
to
4dc214c
aneeshusa
force-pushed the
aneeshusa:add-mach-bootstrap-test
branch
from
a92b5ff
to
1feaa07
aneeshusa
force-pushed the
aneeshusa:add-mach-bootstrap-test
branch
2 times, most recently
to
a4d5348
|
It seems the Travis builders are detected as |
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Apr 12, 2017
…=jdm Allow bootstrapping on Debian <!-- Please describe your changes on the following line: --> This is needed for servo/saltfs#631, since the Travis builders are detected as `'debian'` for some reason. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because the test will be in saltfs <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16389) <!-- Reviewable:end -->
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Apr 13, 2017
…=jdm Allow bootstrapping on Debian <!-- Please describe your changes on the following line: --> This is needed for servo/saltfs#631, since the Travis builders are detected as `'debian'` for some reason. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because the test will be in saltfs <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16389) <!-- Reviewable:end -->
aneeshusa
force-pushed the
aneeshusa:add-mach-bootstrap-test
branch
3 times, most recently
from
10abca7
to
2f49cab
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 13, 2017
…upport-debian-for-mach-bootstrap); r=jdm <!-- Please describe your changes on the following line: --> This is needed for servo/saltfs#631, since the Travis builders are detected as `'debian'` for some reason. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because the test will be in saltfs <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 2e82d98afff696dfd574087a0806383a6abc4c78 --HG-- extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear extra : subtree_revision : 86333237f56fdbd41bfb84a1605efb3fee06b215
aneeshusa
force-pushed the
aneeshusa:add-mach-bootstrap-test
branch
5 times, most recently
from
0ecfb7c
to
cb5bcef
aneeshusa
force-pushed the
aneeshusa:add-mach-bootstrap-test
branch
from
cb5bcef
to
6dd2595
|
Now blocked on servo/servo#16505. |
aneeshusa
force-pushed the
aneeshusa:add-mach-bootstrap-test
branch
from
6dd2595
to
80441b5
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Apr 18, 2017
…, r=Wafflespeanut Stop mach bootstrap from segfaulting <!-- Please describe your changes on the following line: --> See the commit message for details; the top-level import of Mako causes `./mach bootstrap` to segfault in glibc while exiting, seems to have to do with the native `_speedups.so` library of MarkupSafe, a Mako dependency. Needed for servo/saltfs#631. cc @emilio to make sure this is OK for stylo (e.g. #13171) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #12103 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because the test is part of servo/saltfs#631 <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16505) <!-- Reviewable:end -->
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Apr 18, 2017
…, r=Wafflespeanut Stop mach bootstrap from segfaulting <!-- Please describe your changes on the following line: --> See the commit message for details; the top-level import of Mako causes `./mach bootstrap` to segfault in glibc while exiting, seems to have to do with the native `_speedups.so` library of MarkupSafe, a Mako dependency. Needed for servo/saltfs#631. cc @emilio to make sure this is OK for stylo (e.g. #13171) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #12103 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because the test is part of servo/saltfs#631 <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16505) <!-- Reviewable:end -->
aneeshusa
force-pushed the
aneeshusa:add-mach-bootstrap-test
branch
from
80441b5
to
b0a5310
|
@bors-servo try |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 18, 2017
…shusa:stop-mach-bootstrap-from-segfaulting); r=Wafflespeanut <!-- Please describe your changes on the following line: --> See the commit message for details; the top-level import of Mako causes `./mach bootstrap` to segfault in glibc while exiting, seems to have to do with the native `_speedups.so` library of MarkupSafe, a Mako dependency. Needed for servo/saltfs#631. cc @emilio to make sure this is OK for stylo (e.g. #13171) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #12103 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because the test is part of servo/saltfs#631 <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 7413c716fb954c1dd27c39929e27bd7b4b188720 --HG-- extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear extra : subtree_revision : b994fad350458883a2b45f665bcbbc69abaccd68
Manishearth
pushed a commit
to Manishearth/gecko-dev
that referenced
this pull request
Apr 21, 2017
…shusa:stop-mach-bootstrap-from-segfaulting); r=Wafflespeanut <!-- Please describe your changes on the following line: --> See the commit message for details; the top-level import of Mako causes `./mach bootstrap` to segfault in glibc while exiting, seems to have to do with the native `_speedups.so` library of MarkupSafe, a Mako dependency. Needed for servo/saltfs#631. cc @emilio to make sure this is OK for stylo (e.g. #13171) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #12103 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because the test is part of servo/saltfs#631 <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 7413c716fb954c1dd27c39929e27bd7b4b188720
Manishearth
pushed a commit
to Manishearth/gecko-dev
that referenced
this pull request
Apr 21, 2017
…upport-debian-for-mach-bootstrap); r=jdm <!-- Please describe your changes on the following line: --> This is needed for servo/saltfs#631, since the Travis builders are detected as `'debian'` for some reason. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because the test will be in saltfs <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 2e82d98afff696dfd574087a0806383a6abc4c78
|
|
The Travis builders are detected as Debian for some reason by bootstrap.
This will ensure that Salt changes or refactors don't break the important `./mach bootstrap` use case. Make sure to test that bootstrap actually uses the local saltfs tree, and doesn't just pull down saltfs via gitfs. Use a new Travis node instead of the existing test node to avoid any side effects caused by the bootstrapper, and for added parallelism.
aneeshusa
force-pushed the
aneeshusa:add-mach-bootstrap-test
branch
from
b0a5310
to
d06e5e1
aneeshusa
force-pushed the
aneeshusa:add-mach-bootstrap-test
branch
2 times, most recently
from
9c0d60f
to
9b37f34
aneeshusa
force-pushed the
aneeshusa:add-mach-bootstrap-test
branch
3 times, most recently
from
2f9da9e
to
6ca52e9
aneeshusa
force-pushed the
aneeshusa:add-mach-bootstrap-test
branch
from
6ca52e9
to
fc0591f
|
|
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 1, 2019
…upport-debian-for-mach-bootstrap); r=jdm <!-- Please describe your changes on the following line: --> This is needed for servo/saltfs#631, since the Travis builders are detected as `'debian'` for some reason. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because the test will be in saltfs <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 2e82d98afff696dfd574087a0806383a6abc4c78 UltraBlame original commit: 29a3856f91a63e538b4984a47045ff4cbb8e2d45
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 1, 2019
…shusa:stop-mach-bootstrap-from-segfaulting); r=Wafflespeanut <!-- Please describe your changes on the following line: --> See the commit message for details; the top-level import of Mako causes `./mach bootstrap` to segfault in glibc while exiting, seems to have to do with the native `_speedups.so` library of MarkupSafe, a Mako dependency. Needed for servo/saltfs#631. cc emilio to make sure this is OK for stylo (e.g. #13171) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #12103 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because the test is part of servo/saltfs#631 <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 7413c716fb954c1dd27c39929e27bd7b4b188720 UltraBlame original commit: 79059fc31d36667d1edd0e11311cd71adba2546e
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
…upport-debian-for-mach-bootstrap); r=jdm <!-- Please describe your changes on the following line: --> This is needed for servo/saltfs#631, since the Travis builders are detected as `'debian'` for some reason. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because the test will be in saltfs <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 2e82d98afff696dfd574087a0806383a6abc4c78 UltraBlame original commit: 29a3856f91a63e538b4984a47045ff4cbb8e2d45
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
…shusa:stop-mach-bootstrap-from-segfaulting); r=Wafflespeanut <!-- Please describe your changes on the following line: --> See the commit message for details; the top-level import of Mako causes `./mach bootstrap` to segfault in glibc while exiting, seems to have to do with the native `_speedups.so` library of MarkupSafe, a Mako dependency. Needed for servo/saltfs#631. cc emilio to make sure this is OK for stylo (e.g. #13171) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #12103 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because the test is part of servo/saltfs#631 <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 7413c716fb954c1dd27c39929e27bd7b4b188720 UltraBlame original commit: 79059fc31d36667d1edd0e11311cd71adba2546e
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
…upport-debian-for-mach-bootstrap); r=jdm <!-- Please describe your changes on the following line: --> This is needed for servo/saltfs#631, since the Travis builders are detected as `'debian'` for some reason. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because the test will be in saltfs <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 2e82d98afff696dfd574087a0806383a6abc4c78 UltraBlame original commit: 29a3856f91a63e538b4984a47045ff4cbb8e2d45
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
…shusa:stop-mach-bootstrap-from-segfaulting); r=Wafflespeanut <!-- Please describe your changes on the following line: --> See the commit message for details; the top-level import of Mako causes `./mach bootstrap` to segfault in glibc while exiting, seems to have to do with the native `_speedups.so` library of MarkupSafe, a Mako dependency. Needed for servo/saltfs#631. cc emilio to make sure this is OK for stylo (e.g. #13171) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #12103 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because the test is part of servo/saltfs#631 <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 7413c716fb954c1dd27c39929e27bd7b4b188720 UltraBlame original commit: 79059fc31d36667d1edd0e11311cd71adba2546e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedApr 12, 2017
•
edited
This is a new test to ensure saltfs changes don't break
./mach bootstrapfor Servo.This change is