Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSet JAVA_HOME env var to OpenJDK 8 for Android builds #638
Conversation
|
@MortimerGoro can you please confirm that JAVA_HOME works with the ant build, so we don't break the current Android build? |
|
@aneeshusa I ran some tests in my machine: Gradle
Ant
My environment:
|
|
Based on these tests setting JAVA_HOME env variable seems safe. |
|
Thanks so much @MortimerGoro! This is ready for review, r? @larsbergstrom |
|
This means that we're probably not going to support cross-compiling from OSX, right? @fabricedesre Is that OK with you? I know that the OSX cross builds have been broken for a little while (don't test => eventually breaks), but this seems to explicitly move us down a road of Linux-only cross builds. Unless that directory should also be present on OSX, too? Otherwise, I'm fine with this, assuming it passes a |
|
I don't personally care about cross compiling from OSX, being a linux user. go ahead! |
The new gradle builds require Java 8, and the existing ant builds also work with Java 8. This is easier than running many `update-alternatives` calls from Salt. Moreover, this allows keeping Java 7 installed together with Java 8.
|
@larsbergstrom It does make sense to template this in the future, though, so I've added a comment to that effect. |
|
|
Set JAVA_HOME env var to OpenJDK 8 for Android builds The new gradle builds require Java 8, and the existing ant builds also work with Java 8. This is easier than running many `update-alternatives` calls from Salt. Moreover, this allows keeping Java 7 installed together with Java 8. Needed for servo/servo#15773. Follow-up to to #617 and #629. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/638) <!-- Reviewable:end -->
|
|
aneeshusa commentedApr 17, 2017
•
edited by larsbergstrom
The new gradle builds require Java 8,
and the existing ant builds also work with Java 8.
This is easier than running many
update-alternativescalls from Salt.Moreover, this allows keeping Java 7 installed together with Java 8.
Needed for servo/servo#15773.
Follow-up to to #617 and #629.
This change is