Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install android tools r25.2.3 concurrently #639

Merged

Update expect script to propagate return codes

Unfortunately, the `android` tool always returns a 0 exit code even in
case of failure, so this does not yet catch failures.
However, the new `sdkmanager` tool seems to return appropriate exit
codes, so this will kick in in the future.

This will prevent errors from passing silently,
such as bad executable bits or incorrect file permissions.
  • Loading branch information
aneeshusa committed Apr 20, 2017
commit ec3ed351fa1e375a4e1cdd5a4fc6c691337f7ae6
@@ -96,6 +96,8 @@ android-sdk-{{ version }}:
"Do you accept the license" { exp_send "y\r" ; exp_continue }
eof
}
catch wait result
exit [lindex $result 3]
'
- runas: servo
- creates:
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.