Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install android tools r25.2.3 concurrently #639

Merged

Add prereq to clean out old SDK when upgrading

The SDK layout has changed due to the new packaging format,
so simply extracting the new archive over the old one will leave
extraneous files around.
To fix this, if we expect to make changes in the `archive.extracted`
state, then completely remove the existing version of the SDK.

Also, unlink the `current` symlink before making changes to an SDK
to avoid processes inadverently using the SDK while it is being changed
(the symlink will be restored once the SDK is done being updated.)
  • Loading branch information
aneeshusa committed Apr 20, 2017
commit f1df6337a7241762576e1c9794a4c46539734505
@@ -55,6 +55,12 @@ android-dependencies:
- pkg: pip
{% for version, sdk in android.sdk.items() if version != 'current' %}
android-sdk-{{ version }}-purge:
file.absent:
- name: {{ common.servo_home }}/android/sdk/{{ version }}
- prereq:
- archive: android-sdk-{{ version }}
android-sdk-{{ version }}:
archive.extracted:
- name: {{ common.servo_home }}/android/sdk/{{ version }}
@@ -101,6 +107,14 @@ android-sdk-{{ version }}:
- file: android-sdk-{{ version }}
{% endfor %}
android-sdk-current-unlink:
file.absent:
- name: {{ common.servo_home }}/android/sdk/current
- prereq:
- archive: android-sdk-{{ android.sdk.current }}
- require_in:
- file: android-sdk-{{ android.sdk.current }}-purge
android-sdk-current:
file.symlink:
- name: {{ common.servo_home }}/android/sdk/current
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.