Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWIP: Support python nightly upload script #642
Conversation
|
This all looks good, code-wise - will do the test deployment stuff early next week when folks are around, in case I burn something down :-) |
1603ff1
to
55a7378
|
The second commit will likely need to be updated to add the Python3 bits to the Windows $PATH in the |
|
@larsbergstrom Do you want me to do this? |
|
@metajack That would help! I'm all day in meetings through Friday afternoon, but will get to it then if you can't. |
|
python3 package not found on windows |
55a7378
to
556c056
556c056
to
d2f6c06
|
I looked into this a little more and I don't think Python3 on Windows is the best direction for this, I will redo this with a different approach. |
|
Doh. Do you have more details? |
|
A few reasons:
This may be worth revisiting down the road, but in the meantime I fixed up the servo PR to not requires saltfs changes. |
aneeshusa commentedApr 21, 2017
•
edited by larsbergstrom
Needed to fix servo/servo#16560.
Note in particular the first Salting on Windows: using Salt to install Python 3.
I haven't tested that at all, so I'd recommend rolling that out using the temporary Salt root.
This change is