Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Support python nightly upload script #642

Closed

Conversation

@aneeshusa
Copy link
Member

aneeshusa commented Apr 21, 2017

Needed to fix servo/servo#16560.

Note in particular the first Salting on Windows: using Salt to install Python 3.
I haven't tested that at all, so I'd recommend rolling that out using the temporary Salt root.


This change is Reviewable

@aneeshusa
Copy link
Member Author

aneeshusa commented Apr 21, 2017

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Apr 22, 2017

This all looks good, code-wise - will do the test deployment stuff early next week when folks are around, in case I burn something down :-)

@aneeshusa aneeshusa force-pushed the aneeshusa:support-python-nightly-upload-script branch from 1603ff1 to 55a7378 Apr 22, 2017
@aneeshusa
Copy link
Member Author

aneeshusa commented Apr 22, 2017

The second commit will likely need to be updated to add the Python3 bits to the Windows $PATH in the build_windows_msvc var in buildbot/master/files/config/environment.py. I'm not sure exactly what the folder will be, so I'll wait until the test deployment to finalize that.

@metajack
Copy link
Contributor

metajack commented Apr 27, 2017

@larsbergstrom Do you want me to do this?

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Apr 27, 2017

@metajack That would help! I'm all day in meetings through Friday afternoon, but will get to it then if you can't.

@metajack
Copy link
Contributor

metajack commented Apr 27, 2017

python3 package not found on windows

@aneeshusa aneeshusa force-pushed the aneeshusa:support-python-nightly-upload-script branch from 55a7378 to 556c056 Apr 27, 2017
aneeshusa added 2 commits Apr 21, 2017
Use the Salt winrepo support to install Python 3.
Because we use gitfs and don't use the default file roots,
add a new file root on the master for winrepo files.
The script is now written in Python and has been made executable,
so there is no suffix.
@aneeshusa aneeshusa force-pushed the aneeshusa:support-python-nightly-upload-script branch from 556c056 to d2f6c06 Apr 27, 2017
@aneeshusa
Copy link
Member Author

aneeshusa commented Apr 27, 2017

I looked into this a little more and I don't think Python3 on Windows is the best direction for this, I will redo this with a different approach.

@aneeshusa aneeshusa changed the title Support python nightly upload script WIP: Support python nightly upload script Apr 27, 2017
@metajack
Copy link
Contributor

metajack commented Apr 27, 2017

Doh. Do you have more details?

@aneeshusa
Copy link
Member Author

aneeshusa commented May 18, 2017

A few reasons:

  • Salt has support for installing Windows packages via MSIs, which actually works. However, it fails when checking to see if the installation succeeds - it either looks for the wrong key or in the wrong list of packages, I don't remember. Hopefully this is better in more up-to-date versions of Salt (we're over a year behind).
  • Python3 on Windows doesn't install a python3 executable, only a python executable, which makes it trickier to make it available on the PATH. There is a py launcher that apparently can be used to invoke the right Python, but it seems a bit messy.

This may be worth revisiting down the road, but in the meantime I fixed up the servo PR to not requires saltfs changes.

@aneeshusa aneeshusa closed this May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.