Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake android sdk 25.2.3 default #644
Merged
Conversation
Remove the old r24.4.1 version.
aneeshusa
force-pushed the
aneeshusa:make-android-sdk-25.2.3-default
branch
from
9abf33f
to
a9e75da
|
@bors-servo r+ |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 29, 2017
…sbergstrom Make android sdk 25.2.3 default Follow up to servo/servo#15773. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/644) <!-- Reviewable:end -->
|
|
|
This has been deployed to |
bors-servo
added a commit
to servo/servo
that referenced
this pull request
May 31, 2017
…ergstrom Remove redundant ANDROID_SDK variables The r25.2.3 Android SDK has been made the current version in saltfs, so we no longer need to override it via environment variable. Follow up to #15773. Requires servo/saltfs#644. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16566) <!-- Reviewable:end -->
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 31, 2017
…eeshusa:remove-android-sdk-override); r=larsbergstrom The r25.2.3 Android SDK has been made the current version in saltfs, so we no longer need to override it via environment variable. Follow up to servo/servo#15773. Requires servo/saltfs#644. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 779edd7c4aaf900f12fab378a378b0fc52d4c628 --HG-- extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear extra : subtree_revision : 0b6b6b2cb7e84cd3e6f492df9489a98464fa9d79
mcmanus
pushed a commit
to mcmanus/gecko
that referenced
this pull request
May 31, 2017
…eeshusa:remove-android-sdk-override); r=larsbergstrom The r25.2.3 Android SDK has been made the current version in saltfs, so we no longer need to override it via environment variable. Follow up to servo/servo#15773. Requires servo/saltfs#644. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 779edd7c4aaf900f12fab378a378b0fc52d4c628
|
@larsbergstrom I checked via Salt and the symlink is still pointing to Due to #684, it may be best to hold off on trying to redeploy this for the moment. |
JerryShih
pushed a commit
to JerryShih/gecko-dev
that referenced
this pull request
Jun 2, 2017
…eeshusa:remove-android-sdk-override); r=larsbergstrom The r25.2.3 Android SDK has been made the current version in saltfs, so we no longer need to override it via environment variable. Follow up to servo/servo#15773. Requires servo/saltfs#644. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 779edd7c4aaf900f12fab378a378b0fc52d4c628
aethanyc
pushed a commit
to aethanyc/gecko-dev
that referenced
this pull request
Jun 5, 2017
…eeshusa:remove-android-sdk-override); r=larsbergstrom The r25.2.3 Android SDK has been made the current version in saltfs, so we no longer need to override it via environment variable. Follow up to servo/servo#15773. Requires servo/saltfs#644. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 779edd7c4aaf900f12fab378a378b0fc52d4c628
|
Linux 1: Linux2: so it should be fine? |
Manishearth
pushed a commit
to Manishearth/gecko-dev
that referenced
this pull request
Jun 11, 2017
…eeshusa:remove-android-sdk-override); r=larsbergstrom The r25.2.3 Android SDK has been made the current version in saltfs, so we no longer need to override it via environment variable. Follow up to servo/servo#15773. Requires servo/saltfs#644. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 779edd7c4aaf900f12fab378a378b0fc52d4c628
brendandahl
pushed a commit
to brendandahl/gecko
that referenced
this pull request
Jul 10, 2017
…eeshusa:remove-android-sdk-override); r=larsbergstrom The r25.2.3 Android SDK has been made the current version in saltfs, so we no longer need to override it via environment variable. Follow up to servo/servo#15773. Requires servo/saltfs#644. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 779edd7c4aaf900f12fab378a378b0fc52d4c628
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
…eeshusa:remove-android-sdk-override); r=larsbergstrom The r25.2.3 Android SDK has been made the current version in saltfs, so we no longer need to override it via environment variable. Follow up to servo/servo#15773. Requires servo/saltfs#644. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 779edd7c4aaf900f12fab378a378b0fc52d4c628 UltraBlame original commit: ae809917d5db3293869402f858ce1cf5e4a72968
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 1, 2019
…eeshusa:remove-android-sdk-override); r=larsbergstrom The r25.2.3 Android SDK has been made the current version in saltfs, so we no longer need to override it via environment variable. Follow up to servo/servo#15773. Requires servo/saltfs#644. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 779edd7c4aaf900f12fab378a378b0fc52d4c628 UltraBlame original commit: ae809917d5db3293869402f858ce1cf5e4a72968
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
…eeshusa:remove-android-sdk-override); r=larsbergstrom The r25.2.3 Android SDK has been made the current version in saltfs, so we no longer need to override it via environment variable. Follow up to servo/servo#15773. Requires servo/saltfs#644. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 779edd7c4aaf900f12fab378a378b0fc52d4c628 UltraBlame original commit: ae809917d5db3293869402f858ce1cf5e4a72968
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedApr 21, 2017
•
edited by larsbergstrom
Follow up to servo/servo#15773.
This change is