Skip to content
This repository was archived by the owner on Dec 16, 2024. It is now read-only.

Comments

Adding gitSha as a step kwarg and env var#648

Closed
zachncst wants to merge 1 commit intoservo:masterfrom
zachncst:servo.saltfs.issue.597
Closed

Adding gitSha as a step kwarg and env var#648
zachncst wants to merge 1 commit intoservo:masterfrom
zachncst:servo.saltfs.issue.597

Conversation

@zachncst
Copy link

@zachncst zachncst commented Apr 27, 2017

To be able to find the pull request for intermittent issues, we need to add the gitSha into the build steps so the PR can be queried from github. More information here: #597. In support of: https://github.com/servo/servo/wiki/Tracking-intermittent-failures-over-time-project


This change is Reviewable

@highfive
Copy link

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @aneeshusa (or someone else) soon.

@aneeshusa
Copy link
Contributor

Thanks for the PR! Now that I think about it some more, getting the PR can be done entirely from mach. mach can call git rev-parse HEAD to get the current commit (since the full git history is available during Buildbot builds), then hit the GitHub API you found to find the relevant PR number. I'd like to keep as much code in servo/servo as possible, so I'm going to close this in favor of that approach.

@aneeshusa aneeshusa closed this Apr 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants