Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Docker for testing on Travis, start on 16.04 support #649

Merged
merged 7 commits into from May 5, 2017

Commits on Apr 27, 2017

  1. Avoid using variables in printf format strings

    This can potentially cause security issues.
    aneeshusa committed Apr 27, 2017
  2. Only use sudo if necessary

    Ubuntu 16.04 Docker images don't come with sudo.
    aneeshusa committed Apr 27, 2017

Commits on Apr 29, 2017

  1. Drop Python requirement for tests to 3.4 from 3.5

    Ubuntu Trusty's Python 3 package supplies 3.4,
    so this makes it possibly to run the tests on Trusty machines
    without manually installing Python 3.5.
    
    To allow running inside Docker,
    create our own virtualenv for Python test dependencies (e.g. `jinja2`).
    Don't use the virtualenvs supplied by Travis.
    Make sure to install some extra Python bits
    that aren't installed by default for Docker.
    
    Rewrite testing code to avoid APIs introduced in Python 3.5.
    Use block indent and early return in tests.
    aneeshusa committed Apr 29, 2017
  2. Support Ubuntu 16.04 for servo-linux1 states

    More work is needed to support the cross build states.
    aneeshusa committed Apr 29, 2017
  3. Skip timezone.system and service.running on Docker

    `service.running` requires talking to init,
    which is not running inside Docker.
    
    `timezone.system` on systemd distros uses timedatectl
    which also wants to talk to a running systemd,
    so skip that on Docker as well.
    aneeshusa committed Apr 29, 2017
  4. Test `servo-linux1` in Docker on 14.04, 16.04

    Use pinned Docker images for 14.04 and 16.04.
    Re-exec the dispatch script inside a running container
    to simulate running the tests on other OSes.
    
    This is not perfect since various states do
    not function properly in containers
    (mainly service-related states),
    but is still better than nothing
    and tests package installation, etc.
    aneeshusa committed Apr 29, 2017
You can’t perform that action at this time.