Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uphomu: Let hiro land his PRs reviewed in bugzilla. #652
Conversation
He's been doing a lot of stylo work recently, and I got tired of delegating all his patches :).
|
@emilio What does this specifically mean here? You're saying that he gets review for the Servo bits in some other place and needs the ability to Sorry for being a bit dense here - the text of this PR and the commit are asking for him to get reviewer privs, which requires review of some of their reviews, and to be allowed to self- |
hiikezoe
commented
May 2, 2017
|
@larsbergstrom It's enough to me that I have the permission to do delegate+ for PRs that patches have been already reviewed in bugzilla. |
|
Right, so this PR puts him in the Sorry, wasn't trying to imply self-r+. |
emilio
changed the title
|
Thanks, that will be fine, then :-) @bors-servo r+ |
|
|
homu: Let hiro land his PRs reviewed in bugzilla. He's been doing a lot of stylo work recently, and I got tired of delegating all his patches :). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/652) <!-- Reviewable:end -->
|
|
|
FYI, I have deployed this so bors-servo should now recognize your new permissions. |
emilio commentedMay 1, 2017
•
edited by larsbergstrom
He's been doing a lot of stylo work recently, and I got tired of delegating all
his patches :).
This change is