Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upEnable choosing build machine for force builds #659
Merged
Conversation
This makes it easier to test if changes to a specific build machine are working properly, e.g. the current impetus of seeing if Android-related changes on servo-linux-cross3 are working. Docs: https://docs.buildbot.net/0.8.12/manual/cfg-schedulers.html#buildslavechoiceparameter
|
The only thing I was concerned about was the correct import paths, but I checked in a REPL and I think those should be OK. r? @edunham |
|
@bors-servo r+ Looks good to me. I'll keep an eye on the builds after we roll this out -- if the first one refuses to start, we back this out and try again. |
|
|
bors-servo
added a commit
that referenced
this pull request
May 8, 2017
…ds, r=edunham Enable choosing build machine for force builds This makes it easier to test if changes to a specific build machine are working properly, e.g. the current impetus of seeing if Android-related changes on servo-linux-cross3 are working. Docs: https://docs.buildbot.net/0.8.12/manual/cfg-schedulers.html#buildslavechoiceparameter Fixes: #658. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/659) <!-- Reviewable:end -->
|
|
|
I've just rolled this out and confirmed that the web UI now allows choosing a particular build machine when running a force build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedMay 8, 2017
•
edited
This makes it easier to test if changes to a specific build machine are
working properly, e.g. the current impetus of seeing if Android-related
changes on servo-linux-cross3 are working.
Docs: https://docs.buildbot.net/0.8.12/manual/cfg-schedulers.html#buildslavechoiceparameter
Fixes: #658.
This change is