Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give review privileges to Nical. #666

Merged
merged 1 commit into from May 9, 2017
Merged

Give review privileges to Nical. #666

merged 1 commit into from May 9, 2017

Conversation

@nical
Copy link
Contributor

nical commented May 9, 2017 •
edited by larsbergstrom

r? @nox

This change is Reviewable
@nical
Give review privileges to Nical.
Loading status checks…
b6631dd
@highfive
Copy link

highfive commented May 9, 2017

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @nox (or someone else) soon.
@nox
Copy link
Member

nox commented May 9, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2017

📌 Commit b6631dd has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2017

⌛ Testing commit b6631dd with merge 28615e8...
bors-servo added a commit that referenced this pull request May 9, 2017
@bors-servo
Auto merge of #666 - nical:patch-1, r=nox
Loading status checks…
28615e8 
Give review privileges to Nical.

r? @nox

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/666)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 9, 2017

☀️ Test successful - status-travis
Approved by: nox
Pushing 28615e8 to master...
@bors-servo bors-servo merged commit b6631dd into servo:master May 9, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@larsbergstrom
Copy link
Contributor

larsbergstrom commented May 9, 2017

Please provide references showing that Nical's reviews have been reviewed by another superreviewer before granting r+ powers.

A minimal example is #616, with some relevant links for @avadacatavra.
@nox
Copy link
Member

nox commented May 9, 2017

For posterity:

servo/euclid#173
servo/euclid#157
servo/webrender#356
servo/webrender#357
@Manishearth
Copy link
Member

Manishearth commented May 10, 2017

deployed
@jdm
Copy link
Member

jdm commented May 16, 2017

In hindsight, it may have made more sense to give specific review powers for those repositories instead of general review powers.
@nical
Copy link
Contributor Author

nical commented May 17, 2017

I didn't know we could do that. Don't hesitate to remove my review powers on all repos except euclid and webrender.
@metajack
Copy link
Contributor

metajack commented May 17, 2017

@jdm I didn't know we could do that either.
@jdm
Copy link
Member

jdm commented May 17, 2017

saltfs/homu/files/cfg.toml

Line 81 in 5d3e42b

"extra_reviewers": [ "antrik" ],

@aneeshusa
Copy link
Member

aneeshusa commented May 17, 2017

I've rebased #605 and added a commit there to scope @nical's review privileges to just those two repos.
@aneeshusa
Copy link
Member

aneeshusa commented May 17, 2017

I've updated the Governance page on the wiki to mention the ability to have specific review privileges.
@metajack
Copy link
Contributor

metajack commented May 17, 2017

Thanks @aneeshusa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants
@nical @highfive @nox @bors-servo @larsbergstrom @Manishearth @jdm @metajack @aneeshusa
You can’t perform that action at this time.