Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd Behnam Esfahbod as a reviewer for unicode-bidi #670
Conversation
|
r+ |
|
wait i forget what's our policy on adding reviewers again, do we need core approval? |
|
For our smaller repositories the process can be a bit more fluid. This case is interesting because it's a crate that until now has had very little active development, so we can't really link to any existing reviews. I think this makes sense, however. |
|
|
bors-servo
added a commit
that referenced
this pull request
May 17, 2017
Add Behnam Esfahbod as a reviewer for unicode-bidi @behnam is currently the most active developer of the unicode-bidi crate and has now written or rewritten large portions of the code. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/670) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mbrubeck commentedMay 17, 2017
•
edited by larsbergstrom
@behnam is currently the most active developer of the unicode-bidi crate and has now written or rewritten large portions of the code.
This change is