Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide secrets for `./mach upload-nightly` #675

Merged

Conversation

@aneeshusa
Copy link
Member

aneeshusa commented May 22, 2017

Also remove s3cmd related code,
as we now use boto3 for uploads.

Goes along with servo/servo#16565.


This change is Reviewable

Also remove s3cmd related code,
as we now use boto3 for uploads.
@aneeshusa
Copy link
Member Author

aneeshusa commented May 22, 2017

@jdm
Copy link
Member

jdm commented May 24, 2017

@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2017

📌 Commit c95de05 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2017

Testing commit c95de05 with merge d20c76c...

bors-servo added a commit that referenced this pull request May 24, 2017
…y, r=jdm

Provide secrets for `./mach upload-nightly`

Also remove s3cmd related code,
as we now use boto3 for uploads.

Goes along with servo/servo#16565.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/675)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2017

☀️ Test successful - status-travis
Approved by: jdm
Pushing d20c76c to master...

@bors-servo bors-servo merged commit c95de05 into servo:master May 24, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.