Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 4/5 of the new macs #677

Merged
merged 2 commits into from May 25, 2017
Merged

Add 4/5 of the new macs #677

merged 2 commits into from May 25, 2017

Conversation

@edunham
Copy link
Contributor

edunham commented May 24, 2017

See #674 (comment).

Test that the 4 completed new builders are actually working, and free up a bit of capacity, while I finish up with mac9.

Also format these lines to have less icky diffs as we add and remove others.


This change is Reviewable

@larsbergstrom
Copy link
Contributor

larsbergstrom commented May 24, 2017

You can r=me after it passes :-)

@jdm
Copy link
Member

jdm commented May 25, 2017

[ FAIL ] Buildbot master config lint check failed:

         ./buildbot/master/files/config/master.cfg:21:14: E124 closing bracket does not match visual indentation
@edunham
Copy link
Contributor Author

edunham commented May 25, 2017

oh gosh dangit it passed flake8 :/ fixing

@larsbergstrom
Copy link
Contributor

larsbergstrom commented May 25, 2017

That works for me. Can either r+ or squash and r+, whichever you prefer.

@edunham
Copy link
Contributor Author

edunham commented May 25, 2017

@bors-servo r=larsbergstrom

@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2017

📌 Commit 21b277f has been approved by larsbergstrom

@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2017

Testing commit 21b277f with merge d8f1e02...

bors-servo added a commit that referenced this pull request May 25, 2017
Add 4/5 of the new macs

See #674 (comment).

Test that the 4 completed new builders are actually working, and free up a bit of capacity, while I finish up with mac9.

Also format these lines to have less icky diffs as we add and remove others.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/677)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2017

☀️ Test successful - status-travis
Approved by: larsbergstrom
Pushing d8f1e02 to master...

@bors-servo bors-servo merged commit 21b277f into servo:master May 25, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.