Skip to content

/ saltfs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install sccache #688

Merged
merged 1 commit into from Sep 22, 2017
Merged

Install sccache #688

merged 1 commit into from Sep 22, 2017

Conversation

@aneeshusa
Copy link
Member

aneeshusa commented Jun 5, 2017 •
edited by larsbergstrom

Part of servo/servo#17106.

This change is Reviewable
@aneeshusa
Copy link
Member Author

aneeshusa commented Jun 5, 2017

r? @larsbergstrom
cc @luser
@aneeshusa aneeshusa mentioned this pull request Jun 5, 2017
Closed
3 of 5 tasks complete
@aneeshusa aneeshusa force-pushed the aneeshusa:install-sccache branch from 3d14fc0 to 402931e Jun 6, 2017
@larsbergstrom
larsbergstrom reviewed Jun 6, 2017
View changes
servo-build-dependencies/ci.sls
sccache:
file.managed:
- name: {{ sccache.destination }}
- source: https://s3.amazonaws.com/rust-lang-ci/rust-ci-mirror/{{ sccache.version }}-sccache-{{ sccache.platform }}

This comment has been minimized.

Sign in to view
Copy link
@larsbergstrom

larsbergstrom Jun 6, 2017

Contributor

Just one question - where does this come from? Do we want our own for Servo? cc @edunham

This comment has been minimized.

Sign in to view
Copy link
@aneeshusa

aneeshusa Jun 7, 2017

Author Member

Official binary releases are not yet available for sccache, so per suggestion I copied these links from rust-lang/rust CI scripts.

This comment has been minimized.

Sign in to view
Copy link
@larsbergstrom

larsbergstrom Jun 7, 2017

Contributor

Makes sense - sounds good to me! This is r=me, then. Looks like the travis failure is just atimeout to repo.saltstack.com?

This comment has been minimized.

Sign in to view
Copy link
@aneeshusa

aneeshusa Jun 7, 2017

Author Member

I wish, there's a real test failure on the cross build due to the Android SDK check I added, this looks like it might require some yak shaving. Investigating.
@aneeshusa aneeshusa force-pushed the aneeshusa:install-sccache branch from 402931e to 1a5a57d Jun 7, 2017
@aneeshusa aneeshusa mentioned this pull request Jun 7, 2017
Open
@bors-servo
Copy link
Contributor

bors-servo commented Jun 14, 2017

☔ The latest upstream changes (presumably #694) made this pull request unmergeable. Please resolve the merge conflicts.
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Aug 1, 2017

Does this just need a rebase now that all the Android SDK build stuff has been updated?
@aneeshusa aneeshusa force-pushed the aneeshusa:install-sccache branch from 1a5a57d to 646cc67 Sep 12, 2017
@aneeshusa
Install sccache on all builders
Loading status checks…
63f02a6 
This is in a new `servo-build-dependencies.ci` SLS for 2 reasons:
- sccache is a CI detail, not a hard dependency,
  so this separate file will not be invoked by `mach bootstrap`
- Can target Windows without needing to update the main
  servo-build-depenendencies.init file for compatibility
@aneeshusa aneeshusa force-pushed the aneeshusa:install-sccache branch from 646cc67 to 63f02a6 Sep 12, 2017
@aneeshusa
Copy link
Member Author

aneeshusa commented Sep 12, 2017

@bors-servo retry
I've updated this with a workaround for the failing Android SDK test; I think there is a slightly better way possible but it requires a newer Salt and/or a bunch of backporting, so this is simpler.
This should clean up the builds that failed due to force pushing and being unable to find the previous SHA.
Looking at the saltfs build history, we also seem to be hitting travis-ci/travis-ci#8363. I can look for a temporary workaround for that if we don't want to wait.
@jdm
Copy link
Member

jdm commented Sep 12, 2017

@bors-servo: r=larsberg
@bors-servo
Copy link
Contributor

bors-servo commented Sep 12, 2017

📌 Commit 63f02a6 has been approved by larsberg
bors-servo added a commit that referenced this pull request Sep 12, 2017
@bors-servo
Auto merge of #688 - aneeshusa:install-sccache, r=larsberg
Loading status checks…
faf753b 
Install sccache

Part of servo/servo#17106.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/688)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 12, 2017

⌛ Testing commit 63f02a6 with merge faf753b...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 12, 2017

💔 Test failed - status-travis
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Sep 12, 2017

hrm:

$ export GHTOKENLINE=[secure]

The previous command failed, possibly due to a malformed secure environment variable.

Please be sure to escape special characters such as ' ' and '$'.

For more information, see https://docs.travis-ci.com/user/encryption-keys.

Does that look familiar?
@aneeshusa
Copy link
Member Author

aneeshusa commented Sep 12, 2017

@larsbergstrom that's a separate problem; I thought I had an issue tracking that, but not yet it seems. We're not using this variable (I think it was for a PR we decided not to merge), so it should be unset at some point, but that isn't causing the test failure.

The actual test failure is caused by travis-ci/travis-ci#8363; we want to get Python 3.5 but are getting a weird Python 3.4 instead, causing the test failure. If you want sccache now we can add a workaround, or we can wait for Travis to fix this.
@aneeshusa
Copy link
Member Author

aneeshusa commented Sep 22, 2017

@bors-servo r=larsbergstrom
@bors-servo
Copy link
Contributor

bors-servo commented Sep 22, 2017

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: #716
@bors-servo
Copy link
Contributor

bors-servo commented Sep 22, 2017

📌 Commit 63f02a6 has been approved by larsbergstrom
@bors-servo
Copy link
Contributor

bors-servo commented Sep 22, 2017

⌛ Testing commit 63f02a6 with merge e4a1d01...
bors-servo added a commit that referenced this pull request Sep 22, 2017
@bors-servo
Auto merge of #688 - aneeshusa:install-sccache, r=larsbergstrom
Loading status checks…
e4a1d01 
Install sccache

Part of servo/servo#17106.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/688)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 22, 2017

☀️ Test successful - status-travis
Approved by: larsbergstrom
Pushing e4a1d01 to master...
@bors-servo bors-servo merged commit 63f02a6 into servo:master Sep 22, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
homu Test successful
Details
@aneeshusa aneeshusa mentioned this pull request Sep 28, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsbergstrom larsbergstrom

Assignees

@larsbergstrom larsbergstrom

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@aneeshusa @bors-servo @larsbergstrom @jdm @highfive
You can’t perform that action at this time.