Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install and run servo-gecko-try on its own minion #700

Closed
wants to merge 1 commit into from

Conversation

@edunham
Copy link
Contributor

edunham commented Jun 14, 2017

Roughly the same setup as intermittent-tracker, with the notable difference
that we manage ssh keys for the user and they live in the pillar.

I fully expect the tests to break at first and will ping someone when I think it's properly ready for review -- feel free to ignore this PR for now.


This change is Reviewable

@aneeshusa
Copy link
Member

aneeshusa commented Jun 21, 2017

I haven't looked at the rest of this, but I would like this to use a separate user (servo-gecko-try) instead of the servo user, as part of #421.

Roughly the same setup as intermittent-tracker, with the notable difference
that we manage ssh keys for the user and they live in the pillar.

This also uses its own user, servo-gecko-try, as part of
#421.
@edunham edunham force-pushed the edunham:servo-gecko-try branch from 2bf7933 to 8d2eac8 Jun 30, 2017
@edunham
Copy link
Contributor Author

edunham commented Jun 30, 2017

User stuff fixed as requested. I would like to land this soon to get it deployed and make life easier for the Gecko devs if possible.

Copy link
Member

aneeshusa left a comment

I'll check this out in Vagrant and likely have more feedback on the PR. Also, we'll want to add requisites to a bunch of the states to ensure correct ordering.

@@ -39,3 +39,8 @@ base:
- intermittent-tracker
- nginx
- salt.master

'servo-gecko-try':
- common

This comment has been minimized.

Copy link
@aneeshusa

aneeshusa Jun 30, 2017

Member

This is no longer needed since we make a separate user account.

exec /home/servo/servo-gecko-try/_venv/bin/servo-gecko-try

setuid servo
setgid servo

This comment has been minimized.

Copy link
@aneeshusa

aneeshusa Jun 30, 2017

Member

Update both to servo-gecko-try.

start on (local-filesystems and net-device-up IFACE!=lo)
stop on runlevel [016]

env HOME=/home/servo

This comment has been minimized.

Copy link
@aneeshusa

aneeshusa Jun 30, 2017

Member

/home/servo-gecko-try


env HOME=/home/servo

chdir /home/servo/servo-gecko-try

This comment has been minimized.

Copy link
@aneeshusa

aneeshusa Jun 30, 2017

Member

/home/servo-gecko-try

'servo-clone': '/home/servo/servo-clone',
'm-c': '/home/servo/m-c-clone',
'autoland': '/home/servo/autoland-clone',
'vct': '/home/servo/.mozbuild/verson-control-tools',

This comment has been minimized.

Copy link
@aneeshusa

aneeshusa Jun 30, 2017

Member

Update these paths to be under /home/servo-gecko-try.

{% from tpldir ~ '/map.jinja' import servo-gecko-try %}
user-acct:
user.present:

This comment has been minimized.

Copy link
@aneeshusa

aneeshusa Jun 30, 2017

Member

Move this under the servo-gecko-try ID. The name parameter can then be omitted.
TODO for me: I need to double check if this will also create the group automatically.

packages:
pkg.installed:
- names:

This comment has been minimized.

Copy link
@aneeshusa

aneeshusa Jun 30, 2017

Member

Use pkgs instead of names, per the style guide. This can also get moved under servo-gecko-try.

This comment has been minimized.

Copy link
@aneeshusa

aneeshusa Jun 30, 2017

Member

Also, add git here and remove it from top.sls.

- system_site_packages: False
pip.installed:
- pkgs:
- git+https://github.com/Manishearth/servo-gecko-try.git

This comment has been minimized.

Copy link
@aneeshusa

aneeshusa Jun 30, 2017

Member

Can we get this published to PyPi?


[ui]
username = Bors <whatever@whatever.com>
ssh = ssh -l 'borsusername@bors.com' -i '/home/servo/.ssh/id_rsa.pub'

This comment has been minimized.

Copy link
@aneeshusa

aneeshusa Jun 30, 2017

Member

Can we update the identity to match bors-servo?
Also update the key location.

@edunham
Copy link
Contributor Author

edunham commented May 3, 2018

VCS sync is no more, so try is no longer needed.

@edunham edunham closed this May 3, 2018
/home/servo-gecko-try/servo-gecko-try/config.json:
file.managed:
- source: salt://{{ tlpdir }}/files/config.json

This comment has been minimized.

Copy link
@eliasp

eliasp May 4, 2018

Typo: tlpdirtpldir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.