Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upInstall and run servo-gecko-try on its own minion #700
Conversation
|
I haven't looked at the rest of this, but I would like this to use a separate user ( |
|
User stuff fixed as requested. I would like to land this soon to get it deployed and make life easier for the Gecko devs if possible. |
|
I'll check this out in Vagrant and likely have more feedback on the PR. Also, we'll want to add requisites to a bunch of the states to ensure correct ordering. |
| @@ -39,3 +39,8 @@ base: | |||
| - intermittent-tracker | |||
| - nginx | |||
| - salt.master | |||
|
|
|||
| 'servo-gecko-try': | |||
| - common | |||
This comment has been minimized.
This comment has been minimized.
| exec /home/servo/servo-gecko-try/_venv/bin/servo-gecko-try | ||
|
|
||
| setuid servo | ||
| setgid servo |
This comment has been minimized.
This comment has been minimized.
| start on (local-filesystems and net-device-up IFACE!=lo) | ||
| stop on runlevel [016] | ||
|
|
||
| env HOME=/home/servo |
This comment has been minimized.
This comment has been minimized.
|
|
||
| env HOME=/home/servo | ||
|
|
||
| chdir /home/servo/servo-gecko-try |
This comment has been minimized.
This comment has been minimized.
| 'servo-clone': '/home/servo/servo-clone', | ||
| 'm-c': '/home/servo/m-c-clone', | ||
| 'autoland': '/home/servo/autoland-clone', | ||
| 'vct': '/home/servo/.mozbuild/verson-control-tools', |
This comment has been minimized.
This comment has been minimized.
| {% from tpldir ~ '/map.jinja' import servo-gecko-try %} | ||
| user-acct: | ||
| user.present: |
This comment has been minimized.
This comment has been minimized.
aneeshusa
Jun 30, 2017
Member
Move this under the servo-gecko-try ID. The name parameter can then be omitted.
TODO for me: I need to double check if this will also create the group automatically.
| packages: | ||
| pkg.installed: | ||
| - names: |
This comment has been minimized.
This comment has been minimized.
aneeshusa
Jun 30, 2017
Member
Use pkgs instead of names, per the style guide. This can also get moved under servo-gecko-try.
This comment has been minimized.
This comment has been minimized.
| - system_site_packages: False | ||
| pip.installed: | ||
| - pkgs: | ||
| - git+https://github.com/Manishearth/servo-gecko-try.git |
This comment has been minimized.
This comment has been minimized.
|
|
||
| [ui] | ||
| username = Bors <whatever@whatever.com> | ||
| ssh = ssh -l 'borsusername@bors.com' -i '/home/servo/.ssh/id_rsa.pub' |
This comment has been minimized.
This comment has been minimized.
aneeshusa
Jun 30, 2017
Member
Can we update the identity to match bors-servo?
Also update the key location.
|
VCS sync is no more, so try is no longer needed. |
| /home/servo-gecko-try/servo-gecko-try/config.json: | ||
| file.managed: | ||
| - source: salt://{{ tlpdir }}/files/config.json |
edunham commentedJun 14, 2017
•
edited by larsbergstrom
Roughly the same setup as intermittent-tracker, with the notable difference
that we manage ssh keys for the user and they live in the pillar.
I fully expect the tests to break at first and will ping someone when I think it's properly ready for review -- feel free to ignore this PR for now.
This change is