Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Mozilla central servo sync account as an operator. #702

Merged
merged 1 commit into from Jun 22, 2017

Conversation

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Jun 19, 2017

r? @edunham

@globau tells me that https://github.com/moz-servo-sync is the account that sheriff backouts will appear as. In order to auto-approve and support treeclosed, I was thinking that it would make sense to make it an operator.


This change is Reviewable

@edunham
Copy link
Contributor

edunham commented Jun 20, 2017

@larsbergstrom I agree with the idea of giving a shared sheriff account sufficient perms to close the tree. Can you or @globau point me to docs on:

  • Who gets access to that account Especially, who hands out access when they decide that a new sheriff needs it?
  • When they get access, what docs will a new account collaborator read to learn what they should and shouldn't do with it? (I'd like to make sure our instructions there are kept up to date if tree closure ever changes)
  • When someone leaves, what's the process for deprovisioning them from the shared account?

Even if these docs are behind a Mozilla LDAP wall, I would like to look over them just to make sure we aren't accidentally introducing a huge vulnerability by adding this account.

@globau
Copy link

globau commented Jun 20, 2017

Who gets access to that account

the only people who have access are those who also have root access to the systems running servo-vcs-sync. ie. selected dev-ops and developers. this excludes sheriffs and contributors.

best to ask fubar about what happens with regards to staffing changes and access.

@larsbergstrom
Copy link
Contributor Author

larsbergstrom commented Jun 21, 2017

From further conversations with @globau, the credentials are stored in a wonderfully secure manner with extremely limited access to the underlying API key. I'm comfortable that the Firefox protections are at least as good as our own protection of the @bors-servo account :-)

@aneeshusa
Copy link
Member

aneeshusa commented Jun 21, 2017

Is this a human account or a bot account? If the latter, are we planning to add another interface for closing the tree than writing GitHub comments to bors-servo?

@globau
Copy link

globau commented Jun 22, 2017

it's a bot account.

lars and i discussed a few times an out of band signalling mechanism such as SQS (it would help reduce race conditions) but it wasn't really viable to fit that into the schedule. if need be we can investigate that later.

@larsbergstrom
Copy link
Contributor Author

larsbergstrom commented Jun 22, 2017

@edunham @metajack Can we get this landed now? We need this ASAP for testing!

@metajack
Copy link
Contributor

metajack commented Jun 22, 2017

@bors-servo r+

I'd appreciate a pointer to the code be left here, or a page created in the wiki so people know where to start looking if something weird happens.

@bors-servo
Copy link
Contributor

bors-servo commented Jun 22, 2017

📌 Commit 817c124 has been approved by metajack

@bors-servo
Copy link
Contributor

bors-servo commented Jun 22, 2017

Testing commit 817c124 with merge 90c52cb...

bors-servo added a commit that referenced this pull request Jun 22, 2017
Add the Mozilla central servo sync account as an operator.

r? @edunham

@globau tells me that https://github.com/moz-servo-sync is the account that sheriff backouts will appear as. In order to auto-approve and support `treeclosed`, I was thinking that it would make sense to make it an `operator`.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/702)
<!-- Reviewable:end -->
@larsbergstrom
Copy link
Contributor Author

larsbergstrom commented Jun 22, 2017

The Gecko side backout code is here:
https://bugzilla.mozilla.org/show_bug.cgi?id=1365181

@bors-servo
Copy link
Contributor

bors-servo commented Jun 22, 2017

💔 Test failed - status-travis

@larsbergstrom
Copy link
Contributor Author

larsbergstrom commented Jun 22, 2017

@bors-servo retry

  • repo timeout thing
@bors-servo
Copy link
Contributor

bors-servo commented Jun 22, 2017

Testing commit 817c124 with merge e013e00...

bors-servo added a commit that referenced this pull request Jun 22, 2017
Add the Mozilla central servo sync account as an operator.

r? @edunham

@globau tells me that https://github.com/moz-servo-sync is the account that sheriff backouts will appear as. In order to auto-approve and support `treeclosed`, I was thinking that it would make sense to make it an `operator`.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/702)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 22, 2017

☀️ Test successful - status-travis
Approved by: metajack
Pushing e013e00 to master...

@bors-servo bors-servo merged commit 817c124 into servo:master Jun 22, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@aneeshusa
Copy link
Member

aneeshusa commented Sep 28, 2017

I deployed this yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.