Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the max to 9002 so that we can use 9001 and reasonable numbers. #705

Merged
merged 1 commit into from Jun 23, 2017

Conversation

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Jun 23, 2017

r? @edunham or @Manishearth or @metajack

(anybody, really)

See IRC convo at:
http://logs.glob.uno/?c=mozilla%23servo#c704856

This will allow @bors-servo force r+ p=9000 treeclosed=9001 to work for Firefox.

cc @globau


This change is Reviewable

@Manishearth
Copy link
Member

Manishearth commented Jun 23, 2017

@bors-servo r+

I still find the concept of a max priority unnecessary

@bors-servo
Copy link
Contributor

bors-servo commented Jun 23, 2017

📌 Commit ad9a19a has been approved by Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Jun 23, 2017

Testing commit ad9a19a with merge 6b51907...

bors-servo added a commit that referenced this pull request Jun 23, 2017
Move the max to 9002 so that we can use 9001 and reasonable numbers.

r? @edunham or @Manishearth or @metajack

(anybody, really)

See IRC convo at:
http://logs.glob.uno/?c=mozilla%23servo#c704856

This will allow `@bors-servo force r+ p=9000 treeclosed=9001` to work for Firefox.

cc @globau

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/705)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 23, 2017

💔 Test failed - status-travis

@larsbergstrom
Copy link
Contributor Author

larsbergstrom commented Jun 23, 2017

@bors-servo retry

  • repo.saltstack.com stuff
@bors-servo
Copy link
Contributor

bors-servo commented Jun 23, 2017

Testing commit ad9a19a with merge c7ae685...

bors-servo added a commit that referenced this pull request Jun 23, 2017
Move the max to 9002 so that we can use 9001 and reasonable numbers.

r? @edunham or @Manishearth or @metajack

(anybody, really)

See IRC convo at:
http://logs.glob.uno/?c=mozilla%23servo#c704856

This will allow `@bors-servo force r+ p=9000 treeclosed=9001` to work for Firefox.

cc @globau

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/705)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 23, 2017

☀️ Test successful - status-travis
Approved by: Manishearth
Pushing c7ae685 to master...

@bors-servo bors-servo merged commit ad9a19a into servo:master Jun 23, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@aneeshusa
Copy link
Member

aneeshusa commented Sep 28, 2017

This is deployed; should we document the @bors-servo force r+ p=9000 treeclosed=9001 flow somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.