Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove all old logs, not just the zipped up ones. #710
Conversation
|
Travis has failed twice now on assorted intermittents unrelated to this change. |
|
I find that having build history is definitely useful; currently there is ~11GB of history (the disk is 63GB). I would want to keep more than 5 days of history. Here's some approximate numbers I just looked up: Current total bz2 archives (via All files without bz2 files (via I think if we do get rid of logs, we could probably get away with a 6 month or 1 year cutoff. |
| @@ -90,7 +90,7 @@ buildbot-github-listener: | |||
| remove-old-build-logs: | |||
| cron.present: | |||
| - name: 'find {{ common.servo_home }}/buildbot/master/*/*.bz2 -mtime +5 -delete' | |||
| - name: 'find {{ common.servo_home }}/buildbot/master/*/* -mtime +5 -delete' | |||
This comment has been minimized.
This comment has been minimized.
aneeshusa
Aug 20, 2017
Member
I think this will cause an argument too long error, so we'll need to rewrite this differently to not expand all the files in the command line args.
This comment has been minimized.
This comment has been minimized.
aneeshusa
Aug 20, 2017
Member
Getting rid of the second /* at the end should probably do the trick. For the bz2 cron, we can add a -name '*.bz2' as well, and make a separate one for all logs.
edunham commentedAug 2, 2017
•
edited by larsbergstrom
Fixes #506
The only stuff in these directories is the various logs put there by Buildbot, so we're safe to ditch them.
5 days might be a bit to aggressive but it's what we have before to no major ill effects so I left it. If we want partial logs for a month, it'd be just as easy to run a separate cron job to delete the non-zipped files a bit less enthusiastically.
This change is