Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSet utf8 locale #714
Closed
Set utf8 locale #714
+18
−0
Conversation
|
Restricted to ubuntu only since it works there, definitely doesn't on osx, not sure about windows. Second commit is to see if it fixes the apparently intermittent failure stemming from missing /usr/share/i18n/locales, seen in https://travis-ci.org/edunham/saltfs/jobs/268434026 but not https://travis-ci.org/edunham/saltfs/jobs/268434017 . Checking on my system reveals i did it wrong; amendment incoming. |
Fixes #645. Setting it on all Ubuntu hosts. It definitely doesn't work on OSX. Others have hit quirks like saltstack/salt#24827 with locale.present but the latest comment is saying it's ok now. Also force creation of /usr/share/i18n/locales
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
edunham commentedAug 25, 2017
•
edited by larsbergstrom
Fixes #645. Setting it on all hosts
because it's good practices to not just assume they have the right default
across diverse systems.
Others have hit quirks like saltstack/salt#24827
with locale.present but the latest comment is saying it's ok now.
literally just https://docs.saltstack.com/en/latest/ref/states/all/salt.states.locale.html except with a tweaked state name
This change is