Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upInstall full system Python 3 for testing #719
Merged
Conversation
aneeshusa
force-pushed the
aneeshusa:workaround-pyenv-silliness
branch
3 times, most recently
from
3b2f6ea
to
7ac0f39
Travis has changed their pyenv configuration such that the default
Python comes first in the PATH, instead of a custom Python 3.5.
It's a good idea to use the system Python for a few reasons:
- pyenv is not used on macOS, and we don't have it inside Docker
- This makes it easier to run on stock hosts without pyenv,
which is useful for running tests on e.g. our real build machines
Unfortunately, the Ubuntu images do not have the necessary python3
virtualenv package installed, and the name differs between Ubuntu
versions, so these configs require some additional snowflake steps.
Use the Salt python SLS file to ensure that the system Python is
configured appropriately before running the test suite,
which allows encapsulating the complexity into the Salt code for reuse.
Make sure to install Salt first if it is not already installed.
aneeshusa
force-pushed the
aneeshusa:workaround-pyenv-silliness
branch
from
7ac0f39
to
e543350
aneeshusa
changed the title
This was referenced Sep 19, 2017
Merged
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 21, 2017
Install full system Python 3 for testing
Travis has changed their pyenv configuration such that the default
Python comes first in the PATH, instead of a custom Python 3.5.
It's a good idea to use the system Python for a few reasons:
- pyenv is not used on macOS, and we don't have it inside Docker
- This makes it easier to run on stock hosts without pyenv,
which is useful for running tests on e.g. our real build machines
Unfortunately, the Ubuntu images do not have the necessary python3
virtualenv package installed, and the name differs between Ubuntu
versions, so these configs require some additional snowflake steps.
Use the Salt python SLS file to ensure that the system Python is
configured appropriately before running the test suite,
which allows encapsulating the complexity into the Salt code for reuse.
Make sure to install Salt first if it is not already installed.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/719)
<!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedSep 15, 2017
•
edited
Travis has changed their pyenv configuration such that the default
Python comes first in the PATH, instead of a custom Python 3.5.
It's a good idea to use the system Python for a few reasons:
which is useful for running tests on e.g. our real build machines
Unfortunately, the Ubuntu images do not have the necessary python3
virtualenv package installed, and the name differs between Ubuntu
versions, so these configs require some additional snowflake steps.
Use the Salt python SLS file to ensure that the system Python is
configured appropriately before running the test suite,
which allows encapsulating the complexity into the Salt code for reuse.
Make sure to install Salt first if it is not already installed.
This change is