Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install full system Python 3 for testing #719
Install full system Python 3 for testing #719
Changes from all commits
e543350File filter...
Jump to…
Install full system Python 3 for testing
Travis has changed their pyenv configuration such that the default Python comes first in the PATH, instead of a custom Python 3.5. It's a good idea to use the system Python for a few reasons: - pyenv is not used on macOS, and we don't have it inside Docker - This makes it easier to run on stock hosts without pyenv, which is useful for running tests on e.g. our real build machines Unfortunately, the Ubuntu images do not have the necessary python3 virtualenv package installed, and the name differs between Ubuntu versions, so these configs require some additional snowflake steps. Use the Salt python SLS file to ensure that the system Python is configured appropriately before running the test suite, which allows encapsulating the complexity into the Salt code for reuse. Make sure to install Salt first if it is not already installed.